Bootstrap 5.3.0 #1858
Merged
Bootstrap 5.3.0 #1858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regarding #1861: It would probably make sense to try and keep the types-version as close to the actual version as possible. I guess for bootstrap alpha version, we will not have types released? Is it an option to wait until we have an official bootstrap release? Otherwise, I guess we should go with the types version 5.2.6 in package.json... |
|
UI seems okay for me after quickly browsing through all the pages. I had a bit of trouble when switching to your branch with scss compilation not working properly even after a the first If you rebase on main, CI should pass. |
richardebeling
approved these changes
Feb 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to Bootstrap 5.3.0-alpha1 and minor improvements to the vote buttons by adding a hover effect on active buttons.
This is a preparation for further changes and should not greatly change the visual appearance.
Please double-check for any unexpected UI impact.