Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add button to resend "Evaluation started" email to single user #1937

Merged
merged 28 commits into from
Jul 10, 2023
Merged

Add button to resend "Evaluation started" email to single user #1937

merged 28 commits into from
Jul 10, 2023

Conversation

Jonas0000
Copy link
Collaborator

closes #1819

niklasmohrin
niklasmohrin requested changes May 8, 2023
View reviewed changes
evap/staff/views.py Outdated Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
evap/staff/templates/staff_user_form.html Show resolved Hide resolved
evap/staff/templates/staff_user_form.html Outdated Show resolved Hide resolved
evap/staff/templates/staff_user_form.html Outdated Show resolved Hide resolved
evap/staff/templates/staff_user_form.html Outdated Show resolved Hide resolved
janno42
janno42 requested changes May 15, 2023
View reviewed changes
Copy link
Member

@janno42 janno42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! There is one additional requirement I found when testing: When the list of due evaluations is empty, the button should be disabled with a tooltip saying This user currently has no due evaluations.

evap/staff/views.py Outdated Show resolved Hide resolved
janno42
janno42 requested changes May 22, 2023
View reviewed changes
evap/staff/views.py Outdated Show resolved Hide resolved
evap/staff/templates/staff_user_form.html Outdated Show resolved Hide resolved
evap/staff/templates/staff_user_form.html Outdated Show resolved Hide resolved
evap/staff/templates/staff_user_form.html Outdated Show resolved Hide resolved
evap/staff/templates/staff_user_form.html Outdated Show resolved Hide resolved
janno42
janno42 approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@janno42 janno42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Meets requirements
✔️ UI functionality checked

niklasmohrin
niklasmohrin requested changes Jun 5, 2023
View reviewed changes
evap/staff/templates/staff_user_form.html Outdated Show resolved Hide resolved
evap/staff/templates/staff_user_form.html Outdated Show resolved Hide resolved
@janno42
Copy link
Member

janno42 commented Jul 3, 2023

Hi, do you want to continue working on this?

Jonas0000 and others added 2 commits July 4, 2023 00:11
@Jonas0000 @niklasmohrin
Update evap/staff/templates/staff_user_form.html
3268d76 
removed mb-3 class to look normal

Co-authored-by: Niklas Mohrin <dev@niklasmohrin.de>
@niklasmohrin
Update evap/staff/templates/staff_user_form.html
571063a
@niklasmohrin niklasmohrin changed the title added resend emails button Add button to resend "Evaluation started" email to single user Jul 10, 2023
@niklasmohrin niklasmohrin merged commit a80ec12 into e-valuation:main Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janno42 janno42 janno42 approved these changes

@richardebeling richardebeling richardebeling approved these changes

@niklasmohrin niklasmohrin niklasmohrin approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manually send Evaluation Started email for user
4 participants
@Jonas0000 @janno42 @richardebeling @niklasmohrin