Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display number of available reward points on staff page #1941

Merged
merged 4 commits into from
May 22, 2023
Merged

Display number of available reward points on staff page #1941

merged 4 commits into from
May 22, 2023

Conversation

olewoy
Copy link
Collaborator

@olewoy olewoy commented May 15, 2023

closes #1927

@olewoy olewoy force-pushed the show-available-reward-points branch from b33e649 to 010405f Compare May 15, 2023 16:52
@niklasmohrin niklasmohrin requested a review from janno42 May 15, 2023 16:56
niklasmohrin
niklasmohrin reviewed May 15, 2023
View reviewed changes
Copy link
Member

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, some comments

evap/rewards/templates/rewards_reward_point_redemption_events.html Outdated Show resolved Hide resolved
evap/rewards/templates/rewards_reward_point_redemption_events.html Outdated Show resolved Hide resolved
evap/rewards/templates/rewards_reward_point_redemption_events.html Outdated Show resolved Hide resolved
olewoy and others added 3 commits May 22, 2023 17:09
@olewoy @niklasmohrin
Update evap/rewards/templates/rewards_reward_point_redemption_events.…
555d921 
…html

Co-authored-by: Niklas Mohrin <dev@niklasmohrin.de>
@olewoy @niklasmohrin
Update evap/rewards/templates/rewards_reward_point_redemption_events.…
b9f7f09 
…html

Co-authored-by: Niklas Mohrin <dev@niklasmohrin.de>
@olewoy @niklasmohrin
Update evap/rewards/templates/rewards_reward_point_redemption_events.…
5d1844b 
…html

Co-authored-by: Niklas Mohrin <dev@niklasmohrin.de>
janno42
janno42 approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@janno42 janno42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Meets requirements
✔️ UI functionality checked

@janno42
Copy link
Member

janno42 commented May 22, 2023

Thanks! :shipit:

@janno42 janno42 merged commit 75a1002 into e-valuation:main May 22, 2023
florian-str pushed a commit to florian-str/EvaP that referenced this pull request Jun 26, 2023
@olewoy @niklasmohrin @florian-str
Display number of available reward points on staff page (e-valuation#…
87d76b7 
…1941)

* Display number of available reward points on staff page

* Update evap/rewards/templates/rewards_reward_point_redemption_events.html

---------

Co-authored-by: Niklas Mohrin <dev@niklasmohrin.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasmohrin niklasmohrin niklasmohrin left review comments

@richardebeling richardebeling richardebeling approved these changes

@janno42 janno42 janno42 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display number of available reward points
4 participants
@olewoy @janno42 @richardebeling @niklasmohrin