Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable javascript import replacements for ManifestStaticFilesStorage #1954

Merged
merged 2 commits into from
Jun 12, 2023
Merged

Enable javascript import replacements for ManifestStaticFilesStorage #1954

merged 2 commits into from
Jun 12, 2023

Conversation

richardebeling
Copy link
Member

Fixes #1808.

For local testing, I needed to

  1. disable DEBUG
  2. run collectstatic
  3. access the page through apache2 at localhost:8001

niklasmohrin
niklasmohrin approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it works, can't see any remaining downloads of js or css files without hashes

@richardebeling richardebeling merged commit 879b7d8 into e-valuation:main Jun 12, 2023
@richardebeling richardebeling deleted the manifest-js branch June 12, 2023 16:18
florian-str pushed a commit to florian-str/EvaP that referenced this pull request Jun 26, 2023
@richardebeling @he3lixxx @florian-str
Enable javascript import replacements for ManifestStaticFilesStorage (e…
9aaab41 
…-valuation#1954)

* Enable javascript import replacements for ManifestStaticFilesStorage

---------

Co-authored-by: Richard Ebeling <He3lixxx@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasmohrin niklasmohrin niklasmohrin approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ManifestStaticFilesStorage cache-busting doesn't work for JavaScript imports
3 participants
@richardebeling @niklasmohrin @he3lixxx