Fixed duplicate through email cleaning #1956 #1979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasmohrin
requested changes
Jul 10, 2023
There was a problem hiding this comment.
I don't think is exactly what we want, it feels a bit strange that we use our helper clean_email to compare to existing data, but still clean the email of this form here differently. I think it would be better if we would use clean_email directly on the email retrieved from cleaned_data and just have all the email cleaning in this one place - the call to lower later can then be removed too
niklasmohrin
approved these changes
Jul 17, 2023
janno42
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emails now get transformed before being validated / checked for duplicates in the edit form. Therefor, you can avoid accidentally triggering a database constraint.
Fixes #1956