Use builtin types instead of typing module for type hints
#1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasmohrin
force-pushed
the
typing-deprecations
branch
from
3caf214 to
bfe2063
Compare
richardebeling
approved these changes
Jul 10, 2023
niklasmohrin
force-pushed
the
typing-deprecations
branch
from
bfe2063 to
a44bec2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Python 3.9,
typing.Listand friends are deprecated in favor of using the builtin types directly (for examplelist[int]). I usedruffto convert most of the occurrences and also fixed some other stuff it complained about. I think the most controversial change isOptional[T]vsT | None, because there is no deprecation or recommendation against the former and I would intuitively prefer it. However, we then agreed in the meeting that the latter is probably more intuitive for newcomers and kept it.