Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds shortcut button to add exam evaluation #2050

Open
wants to merge 45 commits into
base: main
Choose a base branch
from
Open

Adds shortcut button to add exam evaluation #2050

wants to merge 45 commits into from

Conversation

FSadrieh
Copy link
Collaborator

@FSadrieh FSadrieh commented Oct 23, 2023 •
edited
Loading

@richardebeling richardebeling marked this pull request as draft October 23, 2023 18:30
@FSadrieh FSadrieh marked this pull request as ready for review November 20, 2023 18:08
richardebeling
richardebeling requested changes Nov 21, 2023
View reviewed changes
evap/staff/templates/staff_semester_view.html Outdated Show resolved Hide resolved
evap/staff/urls.py Outdated Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
@janno42 janno42 linked an issue Nov 27, 2023 that may be closed by this pull request
Shortcut button for creating exam evaluation #2008
Open
janno42
janno42 requested changes Nov 27, 2023
View reviewed changes
evap/staff/templates/staff_semester_view_evaluation.html Outdated Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
niklasmohrin
niklasmohrin reviewed Jan 21, 2024
View reviewed changes
Copy link
Member

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a quick skim 👍 I will take a closer look once the modals are done and in use here

evap/staff/views.py Outdated Show resolved Hide resolved
@richardebeling
Copy link
Member

@FSadrieh Modals are merged so you should be un-blocked here now

@Kakadus Kakadus self-requested a review April 15, 2024 18:22
Kakadus
Kakadus requested changes Apr 15, 2024
View reviewed changes
evap/settings.py Outdated Show resolved Hide resolved
evap/staff/templates/staff_semester_view.html Outdated Show resolved Hide resolved
evap/staff/templates/staff_semester_view_evaluation.html Outdated Show resolved Hide resolved
evap/staff/templates/staff_semester_view_evaluation.html Outdated Show resolved Hide resolved
janno42
janno42 reviewed Apr 22, 2024
View reviewed changes
Copy link
Member

@janno42 janno42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not tested yet, will submit another review

evap/staff/templates/staff_semester_view_evaluation.html Outdated Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
@Kakadus Kakadus self-requested a review April 29, 2024 18:01
janno42
janno42 requested changes Apr 29, 2024
View reviewed changes
evap/staff/templates/staff_semester_view_evaluation.html Outdated Show resolved Hide resolved
evap/staff/templates/staff_semester_view_evaluation.html Outdated Show resolved Hide resolved
deployment/localsettings.template.py Outdated Show resolved Hide resolved
Kakadus
Kakadus requested changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@Kakadus Kakadus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good 👍

richardebeling
richardebeling reviewed May 6, 2024
View reviewed changes
evap/staff/tests/test_views.py Outdated Show resolved Hide resolved
evap/staff/tests/test_views.py Outdated Show resolved Hide resolved
evap/staff/tests/test_views.py Outdated Show resolved Hide resolved
evap/staff/tests/test_views.py Outdated Show resolved Hide resolved
evap/staff/tests/test_views.py Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
richardebeling
richardebeling requested changes Jun 9, 2024
View reviewed changes
evap/staff/views.py Outdated Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
evap/evaluation/models.py Outdated Show resolved Hide resolved
evap/evaluation/models.py Outdated Show resolved Hide resolved
evap/evaluation/models.py Outdated Show resolved Hide resolved
evap/evaluation/models.py Outdated Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
niklasmohrin
niklasmohrin reviewed Jun 17, 2024
View reviewed changes
Copy link
Member

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments before I take a closer look at the view code; confirmation modal usage is mostly correct, only some subtleties 👍

evap/staff/templates/staff_semester_view.html Outdated Show resolved Hide resolved
evap/staff/templates/staff_semester_view_evaluation.html Outdated Show resolved Hide resolved
evap/staff/templates/staff_semester_view_evaluation.html Outdated Show resolved Hide resolved
evap/staff/templates/staff_semester_view_evaluation.html Outdated Show resolved Hide resolved
evap/staff/templates/staff_semester_view_evaluation.html Outdated Show resolved Hide resolved
evap/staff/templates/staff_semester_view_evaluation.html Outdated Show resolved Hide resolved
evap/evaluation/models.py Outdated Show resolved Hide resolved
@niklasmohrin niklasmohrin mentioned this pull request Jul 29, 2024
Merged
@Kakadus Kakadus self-requested a review August 26, 2024 17:21
richardebeling
richardebeling requested changes Aug 26, 2024
View reviewed changes
evap/evaluation/models.py Outdated Show resolved Hide resolved
evap/staff/templates/staff_semester_view_evaluation.html Outdated Show resolved Hide resolved
evap/staff/templates/staff_semester_view_evaluation.html Outdated Show resolved Hide resolved
evap/staff/templates/staff_semester_view_evaluation.html Outdated Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
evap/staff/views.py Outdated Show resolved Hide resolved
evap/staff/tests/test_views.py Outdated Show resolved Hide resolved
evap/staff/tests/test_views.py Outdated Show resolved Hide resolved
evap/staff/tests/test_views.py Outdated Show resolved Hide resolved
richardebeling
richardebeling reviewed Nov 17, 2024
View reviewed changes
evap/evaluation/models.py Outdated Show resolved Hide resolved
evap/evaluation/templates/base.html Outdated Show resolved Hide resolved
evap/staff/templates/staff_semester_view_evaluation.html Outdated Show resolved Hide resolved
evap/staff/tests/test_views.py Outdated Show resolved Hide resolved
evap/staff/tests/test_views.py Show resolved Hide resolved
evap/staff/views.py Show resolved Hide resolved
richardebeling
richardebeling approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@richardebeling richardebeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

Kakadus
Kakadus approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@Kakadus Kakadus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I personally like the date constraint, so that the user cannot be lost in years back, or so. We also validate it in the backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kakadus Kakadus Kakadus approved these changes

@richardebeling richardebeling richardebeling approved these changes

@janno42 janno42 Awaiting requested review from janno42

@niklasmohrin niklasmohrin Awaiting requested review from niklasmohrin

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shortcut button for creating exam evaluation
5 participants
@FSadrieh @richardebeling @janno42 @niklasmohrin @Kakadus