Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add error suffix to exceptions #2063

Merged
merged 1 commit into from
Nov 6, 2023
Merged

add error suffix to exceptions #2063

merged 1 commit into from
Nov 6, 2023

Conversation

Kakadus
Copy link
Collaborator

@Kakadus Kakadus commented Nov 6, 2023

While discussing ruff support in #2051, rule N818 failed. Basically, PEP 8 recommends custom exceptions to have the Error suffix:

Because exceptions should be classes, the class naming convention applies here. However, you should use the suffix "Error" on your exception names (if the exception actually is an error).

@richardebeling richardebeling merged commit de8abc2 into e-valuation:main Nov 6, 2023
11 of 12 checks passed
@Kakadus Kakadus mentioned this pull request Nov 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasmohrin niklasmohrin niklasmohrin approved these changes

@richardebeling richardebeling richardebeling approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kakadus @richardebeling @niklasmohrin