Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password login improvements #2155

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

richardebeling
Copy link
Member

  • disallow password login while OIDC login is active
  • aggressively assert that the used login mechanism is intended to be active
  • update password login test
  • warn if we happen to have users in the database with usable passwords (which we don't expect to happen)

In the long run, it might make sense to completely ditch the password field from the database, and also enforce some kind of mocked OIDC login on development setups

@richardebeling richardebeling force-pushed the passwords branch 2 times, most recently from 7c705c6 to 998b7e1 Compare March 29, 2024 14:36
evap/evaluation/tests/test_auth.py Outdated Show resolved Hide resolved
evap/evaluation/tests/test_auth.py Outdated Show resolved Hide resolved
@niklasmohrin
Copy link
Member

In the long run, it might make sense to completely ditch the password field from the database, and also enforce some kind of mocked OIDC login on development setups

that would be cool!

evap/evaluation/tests/test_auth.py Show resolved Hide resolved
@richardebeling richardebeling force-pushed the passwords branch 4 times, most recently from 727a46d to 633c2b7 Compare April 22, 2024 17:49
@richardebeling richardebeling merged commit 6e91de0 into e-valuation:main Apr 22, 2024
10 checks passed
@richardebeling richardebeling deleted the passwords branch April 22, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants