Skip to content

JSON enrollment importer #2187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 61 commits into from
Jun 17, 2025
Merged

JSON enrollment importer #2187

merged 61 commits into from
Jun 17, 2025

Conversation

hansegucker
Copy link
Collaborator

@hansegucker hansegucker commented May 13, 2024 •
edited
Loading

Close #2131

@hansegucker hansegucker marked this pull request as draft May 13, 2024 18:17
@richardebeling richardebeling linked an issue May 17, 2024 that may be closed by this pull request
JSON enrollment data importer (v1) #2131
Closed
richardebeling
richardebeling reviewed May 17, 2024
View reviewed changes
richardebeling
richardebeling requested changes Jun 24, 2024
View reviewed changes
richardebeling
richardebeling reviewed Jul 1, 2024
View reviewed changes
@hansegucker hansegucker force-pushed the json-enrollment-importer branch from 6f2f53a to cc0f045 Compare July 1, 2024 17:46
richardebeling
richardebeling requested changes Jul 15, 2024
View reviewed changes
janno42
janno42 requested changes Jul 29, 2024
View reviewed changes
Copy link
Member

@janno42 janno42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not yet manually tested, because test data doesn't import (course = self.course_map[event["relatedevents"]["gguid"]] KeyError: '0x6')

@janno42
Copy link
Member

janno42 commented Jul 29, 2024

If possible, we should remove the debug info text from the log email

richardebeling
richardebeling reviewed Sep 2, 2024
View reviewed changes
@hansegucker
Copy link
Collaborator Author

If possible, we should remove the debug info text from the log email

Done.

@janno42
Copy link
Member

janno42 commented Mar 13, 2025 •
edited
Loading

Still missing

  • use import names for CourseTypes
  • use import names for Programs
  • tests

@janno42 janno42 force-pushed the json-enrollment-importer branch 3 times, most recently from 742606d to af1825d Compare March 14, 2025 10:09
richardebeling
richardebeling reviewed Mar 17, 2025
View reviewed changes
janno42
janno42 reviewed Apr 28, 2025
View reviewed changes
janno42
janno42 requested changes Apr 28, 2025
View reviewed changes
Copy link
Member

@janno42 janno42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Currently all new evaluations are listed under "New Evaluations" and "Updated Evaluations" in the import log
  • For all "unused events" the programs are currently not imported

@janno42 janno42 force-pushed the json-enrollment-importer branch from b09ecfc to d3fab05 Compare May 5, 2025 16:56
@janno42
Copy link
Member

janno42 commented May 5, 2025

@hansegucker tests are done. some mypy stuff is left, do you want to look into it?

@hansegucker hansegucker marked this pull request as ready for review May 19, 2025 18:16
@hansegucker hansegucker changed the title WIP: JSON enrollment importer JSON enrollment importer May 19, 2025
richardebeling
richardebeling reviewed May 19, 2025
View reviewed changes
niklasmohrin
niklasmohrin reviewed May 19, 2025
View reviewed changes
niklasmohrin
niklasmohrin requested changes May 26, 2025
View reviewed changes
@janno42 janno42 force-pushed the json-enrollment-importer branch from e5e5290 to 85a6a6a Compare June 11, 2025 10:57
@janno42 janno42 force-pushed the json-enrollment-importer branch 2 times, most recently from 631e44f to fdee2a3 Compare June 16, 2025 15:34
@janno42 janno42 force-pushed the json-enrollment-importer branch from fdee2a3 to fec92c1 Compare June 16, 2025 16:07
@hansegucker hansegucker mentioned this pull request Jun 16, 2025
Closed
niklasmohrin
niklasmohrin previously approved these changes Jun 16, 2025
View reviewed changes
Copy link
Member

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🚢

evap/staff/importers/json.py
programs = [
self._get_program(c["cprid"]) for c in data["courses"] if c["cprid"] not in settings.IGNORE_PROGRAMS
]
course.programs.add(*programs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something we want to track as changed?

evap/staff/importers/json.py
Comment on lines +379 to +380
participant_changes = set(evaluation.participants.all()) != set(participants)
evaluation.participants.set(participants)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use our helper here? Or is it wasteful when we don't actually care about the old values?

@janno42 janno42 merged commit d9b17c6 into e-valuation:main Jun 17, 2025
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janno42 janno42 janno42 approved these changes

@richardebeling richardebeling richardebeling left review comments

@niklasmohrin niklasmohrin niklasmohrin left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON enrollment data importer (v1)
4 participants
@hansegucker @janno42 @richardebeling @niklasmohrin