Customizable evaluation results filters #2232
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jooooosef
changed the title
ybrnr
force-pushed
the
iss1786
branch
4 times, most recently
from
0127464 to
ca11745
Compare
janno42
reviewed
Jul 15, 2024
janno42
requested changes
Jul 22, 2024
richardebeling
requested changes
Aug 5, 2024
richardebeling
changed the title
ybrnr
force-pushed
the
iss1786
branch
2 times, most recently
from
9bd5cea to
8aaee00
Compare
ybrnr
force-pushed
the
iss1786
branch
2 times, most recently
from
e77a156 to
73c3a65
Compare
janno42
reviewed
Nov 25, 2024
janno42
reviewed
Nov 25, 2024
janno42
reviewed
Nov 25, 2024
…py müssen wir uns nochmal anschauen, da failed noch ein test
…est_tools zusammengeführt, jetzt alles clean
…aber jetzt geht wieder
made the can_see_general_textanswers and the contributor counterpart also consider the represtened users
make difference between remove_textanswers_that_the_user_must_not_see and can_textanswer_be_seen_by clearer for the future
when users cannot or should not click specific textanswer buttons (because it does not make sense) they should still be there for consistency but should be disabled
Co-authored-by: Yannik <ybrnr@users.noreply.github.com>
implemented smaller changes that were quested in PR. - removed comments - itereated over enums directly - changed the name in this itereation from con_view to contributor_view (same for gen_view) - correclty formatted HTML comment - made things that should be in one line to be in one line - implemented variables for reused expected answers (on method and instance level) in test_views.py Co-authored-by: Yannik <ybrnr@users.noreply.github.com>
showing a tooltip with title is not possible since the tag has the disabled class and therefore does not accept any mouse events. Also: formatted code. Co-authored-by: Yannik <ybrnr@users.noreply.github.com>
Removed tooltip from individual buttons and added a big one on label of the results button groups, since it is not simply possible to show a tooltip on a disabled button. Co-authored-by: Yannik <ybrnr@users.noreply.github.com>
Test seems to be deleted by accident. Added it again.
should (maybe?) be a lil faster. But was recommend so here.
This uses the db to check if one of the represented users is a responsible.
janno42
approved these changes
Jan 13, 2025
|
I just realised that when I use the contributor and go in a contribution where I dont have general_textanswers rights but can edit change the contributor settings that the value for the view_general_results parameter is not set correctly. Why is that? @janno42 |
removed tooltips and changed some labels
richardebeling
requested review from
richardebeling,
niklasmohrin and
Kakadus
Probably because you don't set the value and in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1786