-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset translation in test tearDown #2309
Reset translation in test tearDown #2309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still misses tests like class TestStudentIndexView(WebTestWith200Check):
(found by searching for class Test
)
6079b54
to
0758cb5
Compare
The second failure with seed 7524442357 still breaks on my machine, now even with two tests failing. Maybe we can use https://github.com/asottile/detect-test-pollution ? |
0758cb5
to
2b94bff
Compare
The problem was that |
output of evap/staff/tests/test_views.py
2379: def tearDown(self):
evap/evaluation/tests/tools.py
33: def tearDown(self):
evap/grades/tests.py
54: def tearDown(self): only |
Another seed fixed by this PR 1773734012 :) |
The TestCase tearDown implementation doesn't call super, so we need to inherit form the Mixin first (since MRO is not followed further after first match)
a7bc317
to
84a0ce0
Compare
Fixes order-dependent tests (as caused failure in https://github.com/e-valuation/EvaP/actions/runs/11331145512/job/31510516990)