Skip to content

Commit

Permalink
Hard-coded Code Climate test reporter ID
Browse files Browse the repository at this point in the history
Apparently, there's no easy way to submit coverage reports from GitHub pull request builds
without exposing this reporter ID. Coverage diff reports should now come in from pull
request builds after this commit. The expectation is that Code Climate will comment on the
pull requests and mark the build as failed or succeeded based on the coverage diff.

This commit also disables sending code coverage reports to Codecov, which has been broken
for a while now: codecov/codecov-action#43
  • Loading branch information
Deltik committed Jan 12, 2020
1 parent 08b9041 commit 75d1ae2
Showing 1 changed file with 2 additions and 10 deletions.
12 changes: 2 additions & 10 deletions .github/workflows/test-unit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ on:
env:
MYSQL_DATABASE: app
MYSQL_ROOT_PASSWORD: 'Database Password for Continuous Integration'
CC_TEST_REPORTER_ID: ${{ secrets.CC_TEST_REPORTER_ID }}
#CC_TEST_REPORTER_ID: ${{ secrets.CC_TEST_REPORTER_ID }}
CC_TEST_REPORTER_ID: 8948074581c1ffe7f4e47995c65d7d303882310256edd73536723d7c92adb1e3

jobs:
test:
Expand Down Expand Up @@ -120,15 +121,6 @@ jobs:
--input ./e107_tests/tests/_output/coverage/codeclimate.json
continue-on-error: true

- name: Send code coverage report to Codecov
uses: codecov/codecov-action@v1
with:
token: ${{ secrets.CODECOV_TOKEN }}
file: ./e107_tests/tests/_output/coverage.xml
flags: unit-tests
name: ${{ matrix.interpreter.image }}-${{ matrix.db.image }}
continue-on-error: true

- name: Upload test output
uses: actions/upload-artifact@v1
with:
Expand Down

0 comments on commit 75d1ae2

Please sign in to comment.