Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email notify option/checkbox for new post in forum does not appear. #1343

Closed
martyshep opened this issue Feb 9, 2016 · 7 comments
Closed
Labels
plugin: forum type: bug A problem that should not be happening
Milestone

Comments

@martyshep
Copy link
Contributor

I can see {EMAILNOTIFY} in forum_post_template.php but it does not put a checkbox on the New Post screen to enable or disable (if default behaviour) like it used to in V1.7.

In fact I don't think the Email Notify works, as even when I enable it 'on by default', I do not get notification of a reply to a new forum thread. However, I do get a notification if I select to 'Track' the forum post after I create it.

(I am not a coder, just an e107 user)

@tgtje
Copy link
Contributor

tgtje commented Feb 9, 2016

Different settings achieved ? mail has to be enabled
notify settings enabled ?
forum settings (2) enabled ?
mail working ?
if yes you would see this (files 3-4 days old)
mail

However :notify does work when sending TEST , not by doing stuff on forum... (new topic)
the mail is send when the track is enabled (comment)
so basically replicatable, just some extra testing done

@martyshep
Copy link
Contributor Author

I do see the Forum Tracking icon and that works, since I installed the latest from repository to fix #784 and if I click the track thread after creating a new post, I do get notified but I do not get notified when I enable email notification ON by default.
forum - admin area three percenters mcc 2016-02-09 23-22-05
forum - three percenters mcc 2016-02-09 22-11-43

@martyshep
Copy link
Contributor Author

Also I get the same where when Notify TEST run, email received, but when new thread made on forum no email is received.
admin area three percenters mcc 2016-02-09 23-33-48

@CaMer0n CaMer0n added the type: bug A problem that should not be happening label Feb 10, 2016
@CaMer0n CaMer0n added this to the e107 v2.0.1 milestone Feb 10, 2016
@CaMer0n CaMer0n modified the milestones: e107 v2.1, e107 v2.1.1 Mar 19, 2016
@CaMer0n CaMer0n modified the milestones: e107 v2.1.1, e107 v2.1.2 Apr 6, 2016
@bouncingsoles
Copy link

I have this same issue on an upgraded release of e107 from V1 to V2. Forum email stopped working after upgrade, but using the test events works and other email events like PMs are fine. The bell notification icon is OFF, but I have set it as on in the admin. I can reproduce with a clean install from Github on version on 2.1.2. Newly created forum will not send out thread creation, topic deletes... etc.
PHP Version => 5.4.16

What is weird is if when in the admin I click New topic created: TEST and set it to a class I get the email, but it says todo in the message. Is the feature missing?

/e107_plugins/forum/e_notify.php does have a line that says todo

// TODO - create notify messages + LAN

Let me know if I can provide any more information or assistance.

@martyshep
Copy link
Contributor Author

I've told my users to click the bell icon after creating a new discussion thread on forum as the notify by default does not function. I am not sure what the difference between Topic Tracking and Email notification is? Both are configurable separately in admin.

@bouncingsoles
Copy link

bouncingsoles commented Jul 2, 2016

I think I see the issue in the code and why forum events are not triggered. It seems to be in e107_handlers/notify_class.php. At the very end of the file the code is commented out which is supposed to extend to the e107_plugins/forum/e_notify.php. The following block of code would extend to the forum notify class, but doesn't fire. I am just guessing, but I would need a developer to confirm that. This section at the end is what I am referring to.

/*
if (isset($nt->notify_prefs['plugins']) && e_PAGE != 'notify.php')
{
foreach ($nt->notify_prefs['plugins'] as $plugin_id => $plugin_settings)
{
if(is_readable(e_PLUGIN.$plugin_id.'/e_notify.php'))
{
require_once(e_PLUGIN.$plugin_id.'/e_notify.php');
}
}
}

*/

Inside forum/e_notify.php, which gets extended to by the class has it set as "todo".

    function forum_nt($data)
    {
            $message = 'todo';
            $this->send('forum_nt', LAN_PLUGIN_FORUM_NAME, $message);

@CaMer0n CaMer0n modified the milestones: e107 v2.1.2, e107 v2.1.3 Oct 27, 2016
@CaMer0n CaMer0n modified the milestones: e107 v2.1.3, e107 v2.1.4 Dec 23, 2016
@CaMer0n CaMer0n modified the milestones: e107 v2.1.4, e107 v2.1.5 Jan 17, 2017
@CaMer0n CaMer0n modified the milestones: e107 v2.1.5, e107 v2.1.6 Mar 21, 2017
@CaMer0n CaMer0n modified the milestones: e107 v2.1.6, e107 v2.1.5 Mar 21, 2017
@CaMer0n CaMer0n modified the milestones: e107 v2.1.6, e107 v2.1.7 Aug 10, 2017
@CaMer0n CaMer0n modified the milestones: e107 v2.1.7, e107 2.1.8 Dec 24, 2017
@Moc Moc modified the milestones: e107 2.1.8, e107 2.1.9 Jun 25, 2018
@CaMer0n CaMer0n modified the milestones: e107 2.1.9, e107 2.2.0 Aug 22, 2018
@Moc Moc modified the milestones: e107 2.2.0, Future Feb 4, 2019
@Moc
Copy link
Member

Moc commented Oct 2, 2019

Fixed in e67cf48

To clarify:

  • e_notify is used for Notification triggers set in the admin area. These include things like notifications for reported posts. The e_notify addon for the forum plugin has been updated in the past years and should be functioning fine now.
  • Email notification in the forum is a functionality from v1 which is slowly being replaced by the Topic tracking functionality in v2.

There was a bug which caused the email notification checkbox not to appear, this has been fixed.
I do recommend using the topic tracking method using the 'bell' icon as this is where future developments will focus on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: forum type: bug A problem that should not be happening
Projects
None yet
Development

No branches or pull requests

5 participants