Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: DisplayName and UserName #1728

Closed
LaocheXe opened this issue Jun 23, 2016 · 4 comments
Closed

Issue: DisplayName and UserName #1728

LaocheXe opened this issue Jun 23, 2016 · 4 comments
Assignees
Labels
type: bug A problem that should not be happening
Milestone

Comments

@LaocheXe
Copy link
Member

I went to add a quick user, and have the site set up to allow DisplayName to be different than UserLoginName - I got this message when I added a new user: User name and display name cannot be different (based on the site configuration). Display name set to [b]TestDummy[/b].

@Moc Moc added type: bug A problem that should not be happening status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. labels Jun 29, 2016
@Moc Moc added this to the e107 2.1.8 milestone Feb 28, 2018
@CaMer0n CaMer0n modified the milestones: e107 2.1.8, e107 2.1.9 Jul 18, 2018
@CaMer0n CaMer0n modified the milestones: e107 2.1.9, e107 2.2.0 Aug 22, 2018
@Moc Moc removed the status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. label Jan 10, 2019
@Moc
Copy link
Member

Moc commented Jan 10, 2019

2.5 years later but.... confirmed as a bug.

By default, userclass is left empty even though it should always include the 'member' class (253).

Therefore, this check fails:

if (!check_class($pref['displayname_class'], $allData['data']['user_class']))

@Moc
Copy link
Member

Moc commented Jan 10, 2019

Suggested fix:

		// Fix Display and user name
		$allData['data']['user_class'] = '253'; // Default value, because user will always be part of Members. 

		if (!check_class($pref['displayname_class'], $allData['data']['user_class']))

@CaMer0n What do you think?

@CaMer0n
Copy link
Member

CaMer0n commented May 4, 2019

@Moc Looks like a good solution. Would you like to add it?

@Moc
Copy link
Member

Moc commented May 6, 2019

Done

@Moc Moc closed this as completed in 184fd22 May 6, 2019
CaMer0n added a commit that referenced this issue Feb 10, 2020
…ser" due to modification for Issue #1728. Both issues now resolved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A problem that should not be happening
Projects
None yet
Development

No branches or pull requests

3 participants