Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] SVG icons support, can it be possible? #1958

Closed
rica-carv opened this issue Oct 25, 2016 · 6 comments
Closed

[Question] SVG icons support, can it be possible? #1958

rica-carv opened this issue Oct 25, 2016 · 6 comments
Labels
type: question An ask about behavior that is not found documented anywhere

Comments

@rica-carv
Copy link
Contributor

Since i'm not great fan of monochromatic Bootstrap icons (Glyph or FA), i've been investigating, and read that SVG might be the direction to go regarding icons.

Can this be supported globally (as is Glyphicons and Fontawesome) in e107?

@LaocheXe
Copy link
Member

LaocheXe commented Oct 25, 2016

I had to make my own icons for my Voice eXe plugin - https://github.com/LaocheXe/Voice-eXeSystem/tree/master/voice/fonts

and I have a SVG file of the icons - I used a website that converts images into font icons, but cant remember the site off the top of my head. I would have to say yes to SCG icons support, all I had to do was add the css - https://github.com/LaocheXe/Voice-eXeSystem/blob/master/voice/voice.css

After that, I had to add this e107::css('voice','voice.css'); to e_header.php for my plugin, if one wanted to, they could add the css code and put it into the theme css file

@rica-carv
Copy link
Contributor Author

@LaocheXe Thanks, but in your case, you only ca use them in your plugin, outside of it we all are stuck to Bootstrap font icons, with it's drawbacks....

My question is goes a little bit further, since i want to use SVG icons site wide, ie, even inside the core icons....

A site with its icons based on boostrap and a plugin with SVG icons would be a little bit ankward and poorly designed one, don't you think?

@tgtje
Copy link
Contributor

tgtje commented Oct 25, 2016

take a look at https://useiconic.com/open @rica-carv or G.. for grunticon (not going into the pros and contras)

@LaocheXe
Copy link
Member

@rica-carv yes it's use for my plugin - however, if you want your own icons it's as easy as making or uploading them to the theme fonts folder, adding them to the style.css and placing them down on the site - Also my fonts work site wide via e_header.php which is adding the voice.css style sheet to the rest of the site.

Now I remember something about selecting icons for links, and checking it out, the icons a admin can select are from Bootstrap 2 and Font-Awesome 4, (Icons = Glyphs) - and I think the reason them two are the only ones loaded is because of the theme.

@Moc Moc added the type: question An ask about behavior that is not found documented anywhere label Oct 26, 2016
@rica-carv
Copy link
Contributor Author

@tgtje That looks the way to go, but it seems i need to give a further look to it to find out how it works...
It seems it can have svg to replace the default bootstrap icons generated with i or span tags....
Until now i know that the only way to include svg in html was with the svg tag....

@LaocheXe I knew your approach, i'm using it on my current theme development style sheet. Right now i'm not using svg, but plain & simple png.
But since png are "evil" in tablets and mobile devices, and also are not "bootstrap friendly", i decided the svg approach....

@Moc
Copy link
Member

Moc commented Feb 28, 2018

@rica-carv Is still issue still relevant?

CaMer0n added a commit that referenced this issue Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: question An ask about behavior that is not found documented anywhere
Projects
None yet
Development

No branches or pull requests

4 participants