Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Settings>Search Incorrectly displays Config Option for Downloads when uninstalled. #2003

Closed
MikeyGMT opened this issue Nov 6, 2016 · 6 comments
Assignees
Labels
type: bug A problem that should not be happening
Milestone

Comments

@MikeyGMT
Copy link
Contributor

MikeyGMT commented Nov 6, 2016

In Settings>Search the config form incorrectly displays the Search Option LAN_PLUGIN_DOWNLOAD_NAME (Downloads) even when the Downloads Plugin is uninstalled.

@Moc Moc added the status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. label Nov 6, 2016
@Moc Moc added this to the e107 v2.1.3 milestone Nov 6, 2016
@Moc Moc self-assigned this Nov 6, 2016
@CaMer0n
Copy link
Member

CaMer0n commented Nov 8, 2016

@MikeyGMT Does removing e107_handlers\search\advanced_download.php
e107_handlers\search\search_download.php help?

CaMer0n added a commit that referenced this issue Nov 8, 2016
@MikeyGMT
Copy link
Contributor Author

MikeyGMT commented Nov 8, 2016

The LAN has gone, but the download row and drop down choice box is still there
Will test further.
Mikey

@MikeyGMT
Copy link
Contributor Author

Confirmed on a second test upgraded site, both files removed, but Download option is still displayed in Settings > Search.

@MikeyGMT
Copy link
Contributor Author

Removing comments_download.php is still in the GIT repo removes the LAN but leaves the dropdown choice.
image

@MikeyGMT
Copy link
Contributor Author

Inspect Element
image

@CaMer0n CaMer0n added the type: bug A problem that should not be happening label Nov 29, 2016
@CaMer0n CaMer0n modified the milestones: e107 v2.1.3, e107 v2.1.4 Dec 23, 2016
@Moc Moc removed the type: bug A problem that should not be happening label Jan 17, 2017
@Moc Moc removed their assignment Jan 17, 2017
@Moc Moc modified the milestones: e107 v2.1.5, e107 v2.1.4 Jan 17, 2017
@CaMer0n CaMer0n modified the milestones: e107 v2.1.5, e107 v2.1.6 Mar 21, 2017
@CaMer0n CaMer0n modified the milestones: e107 v2.1.6, e107 v2.1.7 Aug 10, 2017
@CaMer0n CaMer0n modified the milestones: e107 v2.1.7, e107 2.1.8 Dec 24, 2017
@Moc Moc added the type: bug A problem that should not be happening label Feb 28, 2018
@Moc Moc removed the status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. label Feb 28, 2018
@CaMer0n CaMer0n modified the milestones: e107 2.1.8, e107 2.1.9 Jul 18, 2018
@CaMer0n CaMer0n modified the milestones: e107 2.1.9, e107 2.2.0 Aug 22, 2018
@Moc Moc added the status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. label Feb 1, 2019
@Moc Moc modified the milestones: e107 2.2.0, Future Feb 1, 2019
@Moc Moc removed the status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. label Sep 25, 2019
@Moc Moc self-assigned this Sep 25, 2019
@Moc Moc modified the milestones: Future, e107 2.2.2 Sep 25, 2019
@Moc
Copy link
Member

Moc commented Sep 25, 2019

Issue is still occurring, it is caused by the search_prefs. This is the content directly after a clean install:

array (
  'comments_handlers' => 
  array (
    'news' => 
    array (
      'id' => 0,
      'dir' => 'core',
      'class' => '0',
    ),
    'download' => 
    array (
      'id' => 2,
      'dir' => 'core',
      'class' => '0',
    ),
  ),
  'core_handlers' => 
  array (
    'comments' => 
    array (
      'class' => '0',
      'pre_title' => '1',
      'pre_title_alt' => '',
      'chars' => '150',
      'results' => '10',
      'order' => '2',
    ),
    'users' => 
    array (
      'class' => '0',
      'pre_title' => '1',
      'pre_title_alt' => '',
      'chars' => '150',
      'results' => '10',
      'order' => '3',
    ),
  ),
  'google' => '0',
  'multisearch' => '1',
  'mysql_sort' => '1',
  'php_limit' => '',
  'relevance' => '0',
  'selector' => '2',
  'time_restrict' => '0',
  'time_secs' => '60',
  'user_select' => '1',
)

in default_install.xml

<search name="comments_handlers"><![CDATA[array (
  'news' => 
  array (
    'id' => 0,
    'dir' => 'core',
    'class' => '0',
  ),
  'download' => 
  array (
    'id' => 2,
    'dir' => 'core',
    'class' => '0',
  ),
)]]></search>

@CaMer0n Can this be safely removed? Will it be added back when the download plugin is installed?

EDIT: on a clean install, the 'Pages' title is displayed as "LAN_PLUGIN_PAGE_NAME"

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A problem that should not be happening
Projects
None yet
Development

No branches or pull requests

3 participants