Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEF URLs for Download Categories #2486

Open
mostym opened this issue Mar 3, 2017 · 8 comments
Open

SEF URLs for Download Categories #2486

mostym opened this issue Mar 3, 2017 · 8 comments
Labels
Help Wanted plugin: download type: bug A problem that should not be happening type: enhancement An improvement or new feature request
Milestone

Comments

@mostym
Copy link

mostym commented Mar 3, 2017

With the current download plugin, breadcrumbs show

home icon / Downloads / Child Category

While the address bar shows

URL: domain.com/category/8/child-category

Enhancement Request

Breadcrumbs
home icon / Parent / Child Category

URL: domain.com/parent/child

@Moc Moc added the type: enhancement An improvement or new feature request label Mar 3, 2017
CaMer0n added a commit that referenced this issue Apr 10, 2017
@Moc
Copy link
Member

Moc commented Mar 1, 2018

@BigBoiJefe Is this issue resolved in the latest version?

@Moc Moc added this to the e107 2.1.8 milestone Mar 1, 2018
@Moc Moc added the status: awaiting feedback This issue may be fixed and is awaiting the original poster to confirm the fix. label Mar 1, 2018
@mostym
Copy link
Author

mostym commented Mar 1, 2018

When I enable the Site URLS and enable the SEF (experimental) links, I get the following:

SEF Debug Info
File missing: plugins/download/download.phpsega-mega-cd-isos
Matched key: index
Array
(
    [regex] => download/?(.*)$
    [sef] => {alias}/
    [redirect] => {e_PLUGIN}download/download.php$1
    [alias] => download
)

@Jimmi08
Copy link
Contributor

Jimmi08 commented Jun 23, 2018

@Moc I think this is fixed now.

@Moc
Copy link
Member

Moc commented Jun 23, 2018

Closing. Please let me know if it needs to be re-opened.

@Moc Moc closed this as completed Jun 23, 2018
@mostym
Copy link
Author

mostym commented Jun 24, 2018

This is not fixed.

@Jimmi08
Copy link
Contributor

Jimmi08 commented Jun 24, 2018

Ok, so I haven't this problem on e107.sk (or I didn't get what you mean). And with Download I have no Experimental links in URL configuration settings.

@Moc Moc reopened this Jun 24, 2018
@Moc Moc added status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. and removed status: awaiting feedback This issue may be fixed and is awaiting the original poster to confirm the fix. labels Jun 24, 2018
@CaMer0n CaMer0n modified the milestones: e107 2.1.8, e107 2.1.9 Jul 18, 2018
@CaMer0n CaMer0n modified the milestones: e107 2.1.9, e107 2.2.0 Aug 22, 2018
@e107inc e107inc deleted a comment from Jimmi08 Jan 11, 2019
@Moc Moc added type: bug A problem that should not be happening and removed status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. labels Jan 11, 2019
@Moc
Copy link
Member

Moc commented Jan 11, 2019

There's still a bug with the second SEF URL configuration for downloads. The default works fine, but when using the experimental one it shows an error:

image

image

TestParent
TestChild
TestDownloadItem

Rebuilding does not help

@CaMer0n Can you take a look at this one please? There's a wrong reference to the vstore plugin as well, in the e_url.php file of the download plugin.

@CaMer0n
Copy link
Member

CaMer0n commented Apr 11, 2019

@Moc I fixed the problem with index, but there's no quick fix for the experimental profile. It requires a lot of time and work.

@Moc Moc modified the milestones: e107 2.2.0, Future Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted plugin: download type: bug A problem that should not be happening type: enhancement An improvement or new feature request
Projects
None yet
Development

No branches or pull requests

4 participants