gsitemap - improvements for Downloads plugin

[mostym]

Hi there! I noticed that the gsitemap plugin doesn't generate a sitemap for sub-categories, nor individual files in the downloads plugin. Can we get this added? You're too good to me ;)

[Jimmi08]

@BigBoiJefe how you get download categories? I have there no links from download plugin.

[mostym]

@Jimmi08 I created an entry for each download category... However, this does generate a sitemap for sub categories or the individual files.

[Jimmi08]

Thanks. So you did it manually...

[Moc]

Fixed in 226b238

[mostym]

@Moc gsitemap plugin does not include individual files of the subcategories.

[Moc]

@Jimmi08 thoughts?

[Jimmi08]

Probably wrong description of problem, because I am sure it does. There is no limitation for subcategories
$data = $sql->retrieve("download_category", "*", " ORDER BY download_category_order ASC", true);

[mostym]

Subcategories work, individual files that belong to categories don't

[Jimmi08]

@Moc gsitemap plugin does not include individual files of the subcategories.

so now they work?

individual files that belong to categories don't

I can see them

[Jimmi08]

@Moc @CaMer0n
Problem is that e_gsitemap checks download_class against classes 0,252
The query code is from e_rss.php plugin, but there are classes 0,251,252,253 .

What is correct fix? To check visibility field or change class list for gsitemap plugin.
It looks weird if visibility is set differently and user still can see link in rss output.

Thanks

[Moc]

@Jimmi08 I adjusted the e_rss addon for the download plugin to check against the userclasses of the user when logged in. If not logged in, it only displays the public/guest items.

Now for the gsitemap addon, I am not entirely sure what people would like to do. We could do ALL items, but then the admin would need to select which ones to import (this may be a lot of work). We could keep it this way but then not all items are included, and they have to be added manually, which is a lot of work as well.

@mostym @Jimmi08 What do you think?

[Jimmi08]

@Moc Did you use USERCLASS_LIST instead of hardcoded list? Got I this right?

So output is different for registered (login in user) and for quests?

Gsitemap displays only manually (imported) links, you always select what to import and what not (there is no option to import everything). There is no connection with original record (to check visibility etc)

No idea what is correct. Just notes:

• sitemap should have links that I want to be indexed by google. F.e if there is news for only registred members, than it shouldn't be in xml version because google gets error (sometimes 404, sometimes no access, result is double content and other problems)

• download plugin is different - you want the link indexed if visibility is for all (content of page is visible). But if you set visibility to members, why you would want it displayed for google? Google is not member of your site.

[Moc]

Did you use USERCLASS_LIST instead of hardcoded list? Got I this right?
So output is different for registered (login in user) and for quests?

Correct. This works correctly in forum.

I agree with your notes.. but then maybe @mostym wants to have a sitemap for his users (logged in) which also include the download items for logged in users. Not related to google specifically (or xml).

Hmm... difficult.

Btw, I think the download RSS feed is not working. Will look into it.