Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Banners Plugin #3141

Closed
LaocheXe opened this issue May 23, 2018 · 5 comments
Closed

Issue: Banners Plugin #3141

LaocheXe opened this issue May 23, 2018 · 5 comments
Labels
plugin: banner type: bug A problem that should not be happening
Milestone

Comments

@LaocheXe
Copy link
Member

LaocheXe commented May 23, 2018

I enabled the Banners plugin, added the menu into the menu manager in area 2, wont show, did the same in area 104 - no show, even clicked on the e107promo in menu manager banners config - (by the way, broken lans in the menu manager banners config area) - still nothing is showing up. - even tried to debug, and nothing is showing for the banners plugin

@Moc Moc added the type: bug A problem that should not be happening label Jun 23, 2018
@Moc Moc added this to the e107 2.1.9 milestone Jun 23, 2018
@Moc
Copy link
Member

Moc commented Jun 23, 2018

Confirmed

  1. Banner not showing up in the assigned menu area
  2. Broken LAN in menu configure area

@LaocheXe
Copy link
Member Author

I notice {BANNER} shortcode works, sort of - didn't add any parameters to it

bannertest

@Moc
Copy link
Member

Moc commented Feb 1, 2019

I've made some changes:

  • LAN fixed
  • The only thing you need to do after activating the menu in a particular area, is configure which campaign needs to be shown.

@Moc
Copy link
Member

Moc commented Feb 1, 2019

@CaMer0n is it possible to set a default value for a menu pref? Perhaps we can improve the banner plugin by making the default banner (that is inserted during plugin install) show by default.

@CaMer0n
Copy link
Member

CaMer0n commented Feb 1, 2019

@Moc Usually I use varset($pref, 'defaultvalue'); inside the menu itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: banner type: bug A problem that should not be happening
Projects
None yet
Development

No branches or pull requests

3 participants