Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bbcodes in forum titles and breacrumb issue #3245

Closed
Jimmi08 opened this issue Jul 3, 2018 · 6 comments
Closed

bbcodes in forum titles and breacrumb issue #3245

Jimmi08 opened this issue Jul 3, 2018 · 6 comments
Labels
plugin: forum type: bug A problem that should not be happening type: enhancement An improvement or new feature request

Comments

@Jimmi08
Copy link
Contributor

Jimmi08 commented Jul 3, 2018

If you use bbcodes in forum title, it works (images and emoticons):
image

But breadrumb title is not able to display emoticons:

image

And in links it looks like this (the same in version 1)
image

Shoudln't be titles in breadcrumbs displayed just text (remove bbcodes?)

Hm, what then left there if there is no text, just bbcode? Any idea how to get titles this way?

@Moc Moc added type: bug A problem that should not be happening type: enhancement An improvement or new feature request plugin: forum labels Jul 5, 2018
@SimSync
Copy link
Contributor

SimSync commented Aug 9, 2018

@Jimmi08 The not parsed emoticon looks like a bug.
But the issue on the drop down isn't so easy solvable. The standard select/option doesn't support images...

@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Aug 9, 2018

@SimSync Thanks.
It should be stripped somehow - only text should left for dropdown. The same for breadcrumbs in my opinion or meta title tag (I didn't check this one). Using only image as forum title should be deprecated/forbiden (in meaning - if you do it, its your problem) . Title should be stripped and if nothing left, forum ID could be displayed (or nothing).

So solution is not parsing this to display those images or emoticons, but displays it in readable form - only form.

@SimSync
Copy link
Contributor

SimSync commented Aug 10, 2018

@Jimmi08 @Moc My proposal would be to restrict the forum title to plain text only and to strip all html or bbcode, incl. emoticons.
In a second step i could imagine to add a new field e.g. forum_image where an image can be assigned to the forum, which will be displayed in the forum table next to the name (before or after is up to the theme designer). This way, the site admins can use images in their forums, but it doesn't interfere with the breadcrump, sef url, jump-to-forum-dropdown, and so on...
@Moc What do you think?

@Moc
Copy link
Member

Moc commented Aug 10, 2018

I agree :)

CaMer0n added a commit that referenced this issue Aug 10, 2018
fixes #3245 eHelper::title2sef() now strips any html or bbcode
@SimSync
Copy link
Contributor

SimSync commented Aug 14, 2018

@Moc see #1412 (once the PR is merged)

@CaMer0n
Copy link
Member

CaMer0n commented Aug 15, 2018

I think you mean PR #3378 ;-) To be merged for v2.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: forum type: bug A problem that should not be happening type: enhancement An improvement or new feature request
Projects
None yet
Development

No branches or pull requests

4 participants