Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bbcode template on forum - removed custom bbcodes #3394

Closed
Jimmi08 opened this issue Aug 22, 2018 · 2 comments
Closed

bbcode template on forum - removed custom bbcodes #3394

Jimmi08 opened this issue Aug 22, 2018 · 2 comments
Labels
plugin: forum type: bug A problem that should not be happening
Milestone

Comments

@Jimmi08
Copy link
Contributor

Jimmi08 commented Aug 22, 2018

Latest changes in forum template vs bbcodes - not all, just this one:

fixes #3317 moved the forum template from core to plugin

c1bec2b

caused that e_bb.php doesn't work and custom bbcodes are not displayed.

The reason is using $tpl = e107::getTemplate($template, 'bbcode', $template);
instead $BBCODE_TEMPLATE_FORUM;

@Moc Moc added type: bug A problem that should not be happening plugin: forum labels Aug 24, 2018
@Moc Moc added this to the e107 2.2.0 milestone Aug 24, 2018
@SimSync
Copy link
Contributor

SimSync commented Aug 26, 2018

@Jimmi08 can you send me such an e_bb.php please or better the whole plugin that implements the e_bb.php?

@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Aug 26, 2018

@SimSync
Forum is set to use bbcodes (system editor is Tinymce, forum plugin use bbcodes)

With version 2.1.9 it looks like this:
image

Before it looks like this:

image

That last one is from this plugin:
https://www.e107.sk/download/18/spoiler-plugin

It's just fixed some old plugin.
bbcode is defined this way (one plugin = one bbcode):

      <?php
      $bb['name']        = 'sp';
      $bb['onclick_var'] = "[sp][/sp]";
      $bb['icon']        = e_PLUGIN_ABS."spoiler/images/spoiler.png";
      $bb['helptext']        = "Spoiler: [sp=subject]Text to be hidden[/sp]";
      $BBCODE_TEMPLATE .= "{BB=sp}";
      $BBCODE_TEMPLATE_SUBMITNEWS .= "{BB=sp}";
      $BBCODE_TEMPLATE_NEWSPOST .= "{BB=sp}";
      $BBCODE_TEMPLATE_ADMIN .= "{BB=sp}";
      $BBCODE_TEMPLATE_CPAGE .= "{BB=sp}";
      $eplug_bb[] = $bb;
      ?>

but then you can have more bbcodes in one plugin.

I tried to add:

      $BBCODE_TEMPLATE_FORUM .= "{BB=sp}";

It's related to using getTemplate().

CaMer0n added a commit that referenced this issue Aug 26, 2018
fixes #3394 Moved loading of e_bb after the loading of the templates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: forum type: bug A problem that should not be happening
Projects
None yet
Development

No branches or pull requests

3 participants