Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download Plugin: Reported links goto non SEF urls #3622

Closed
mostym opened this issue Jan 15, 2019 · 9 comments
Closed

Download Plugin: Reported links goto non SEF urls #3622

mostym opened this issue Jan 15, 2019 · 9 comments
Assignees
@Moc
Labels
plugin: download type: enhancement An improvement or new feature request
Milestone
e107 2.3.0

Comments

@mostym
Copy link

mostym commented Jan 15, 2019

When clicking on the There are unmoderated administrator messages link, download urls are not SEF but instead plugins/download/download.php?view.84963
@Moc Moc added status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. plugin: download labels Jan 16, 2019
@Moc
Copy link
Member

Moc commented Jan 16, 2019 •
edited
Loading

This is heavily outdated and needs to be moved in Download plugin code and database rather than still using the generic table.

Notes:

  • reporting broken downloads
  • e107_admin/message.php

@Moc Moc added type: enhancement An improvement or new feature request and removed status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. labels Jan 16, 2019
@Moc Moc added this to the Future milestone Jan 24, 2019
@Moc Moc self-assigned this Oct 27, 2019
@Moc Moc modified the milestones: Future, e107 2.2.2 Oct 27, 2019
Moc added a commit that referenced this issue Oct 27, 2019
@Moc
#3622 - Download plugin - moving 'Report Broken Download' to e_notify
e5f024e 
Work in progress:
- Convert previous 'download_email' pref
- Move broken download list to download plugin admin  /e107_admin/message.php
Moc added a commit that referenced this issue Oct 27, 2019
@Moc
#3622 - Download plugin LAN clean-up
59e8d07
Moc added a commit that referenced this issue Oct 27, 2019
@Moc
#3622 - Get rid of old download_mail pref
abcce86 
No longer needed now that we have e_notify
@Moc Moc closed this as completed in 1b9251e Oct 27, 2019
@Moc
Copy link
Member

Moc commented Oct 27, 2019

Just finished the rework of 'Broken download reports' functionality in the admin area:

  • Moved away from e107_admin/message.php to its own place in the Downloads admin area.
  • Notification of broken downloads now controlled by e_notify (see Admin Area > Settings > Notify)
  • Updated notification message
  • Added e_dashboard addon to show latest status on broken download reports

@mostym @Jimmi08 Please test and let me know what you think :)

@Moc
Copy link
Member

Moc commented Oct 27, 2019

Oh, you probably have to go to Tools > Database > Scan plugin folders. This way, the system will recognize the new addons (e_notify, e_dashboard).

I still need to add a check somewhere to force that scan.

@Jimmi08
Copy link
Contributor

Jimmi08 commented Oct 27, 2019 •
edited
Loading

I still need to add a check somewhere to force that scan.

Good luck with it. I would use this too :)

By the way, great work, but only way I could test this, is to sync on live site and then you will report something and we will see results. I am sort of time and this is only way how I can help you. Sorry.,

Moc added a commit that referenced this issue Oct 27, 2019
@Moc
#3622 - Broken downloads clean-up
30302db
@Moc Moc reopened this Oct 27, 2019
@Moc
Copy link
Member

Moc commented Oct 27, 2019

Self-note, todo:

  • Make sure that when download_mail pref was selected, the notify is set to admin (or main admin?)
  • Add check for addon changes

Moc added a commit that referenced this issue Oct 28, 2019
@Moc
#3622 - add e_notify check for download plugin
ef2a831
Moc added a commit that referenced this issue Oct 29, 2019
@Moc
#3622 - Rewrite e_notify and e_dashboard check
8a27ac2
Moc added a commit that referenced this issue Oct 29, 2019
@Moc
#3622 - Fix individual deletion of broken dowload reports
104dbed
@CaMer0n
Copy link
Member

CaMer0n commented Jun 1, 2020

@Moc Can this one be closed? Thanks.

@Moc
Copy link
Member

Moc commented Jun 1, 2020 •
edited
Loading

Self-note, todo:

  • Make sure that when download_mail pref was selected, the notify is set to admin (or main admin?)
  • Add check for addon changes

This is still open.

@CaMer0n
Copy link
Member

CaMer0n commented Jun 1, 2020

okay, thanks.

@CaMer0n CaMer0n removed this from the e107 2.3.0 milestone Jun 1, 2020
@Moc Moc added this to the Future milestone Jun 5, 2020
@Moc
Copy link
Member

Moc commented Jun 5, 2020

Actually, I am going to close this one.

Make sure that when download_mail pref was selected, the notify is set to admin (or main admin?)

For now I will not implement this, but we can add it in the future. Manually setting this configuration option would be best, because I cannot predict what the user would like to set (main admin, admin, another class, etc.).

@Moc Moc modified the milestones: Future, e107 2.3.0 Jun 5, 2020
@Moc Moc closed this as completed Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Moc Moc

Labels
plugin: download type: enhancement An improvement or new feature request
Projects
None yet
Milestone
e107 2.3.0
Development

No branches or pull requests
4 participants
@Moc @CaMer0n @Jimmi08 @mostym