Comment turned off

[fizi]

If I turned off the comment (cpage) the comment turned off message not appears ("comment rurned off for this item").

[Moc]

@fizi Which LAN is supposed to display? I can only find LAN_THEME_1 which is specific to the _blank theme

[fizi]

If I disable the comment example on the nesw item - "Comments are locked" - not appears the text on the News. If I enable the comment the number of comments appears.

[Moc]

I found the reason why, but question (perhaps also for @Jimmi08): when comments on news items are disabled, do you really want to show the text that comments are locked? I can make it like this for example:

and for non-bootstrap:

BUT, I can also imagine that you may want to display nothing at all... Ideally, this should be defined by templating but as far as I can see, this method is called anyway regardless of the template.

[Moc]

The same situation applies to custom pages.

Self note:

news: renderComments() in news.php
custom pages: cpagecomments() in page_shortcodes.php

[Moc]

For custom pages. It can be controlled through templating.
I guess we need to modify the news template to do the same thing, so the display of the locked message can be controlled by the template.

Do you agree? @fizi @Jimmi08

[Jimmi08]

@Moc
The correct solution for me (it doesn't mean it's good):

• new post/page - comments OFF, no message
• post with comments, then you set comment OFF, message - commenting was set off.

OR

Allow users to post comments NO - no message (general off, commenting is not available)
Allow users to post comments YES - message, if commenting is set off.

I have no idea (no tested) what happens if there are already comments and you change post/page settings.

[Moc]

@Jimmi08 Yeah I would agree with your second option. I am not a fan of option 1 because it would require storing the 'history' of news items.

[fizi]

I test it...the shortcode {NEWSCOMMENTS} on/off with text work on News page but not work on extend news.

[Moc]

Done. Please test and let me know if this is how you want it.

[fizi]

I tested it but… if the comments disabled the text appears on the News page (see it)

but not appears on the extend news page (see it)

A see you made it that the text appears in the textbox (If you think this is better, then ok)

[Moc]

@fizi Well this doesn't look good haha. Which theme are you using in the screenshot? What is the shortcode that is used in the news template to display that bit that you circled?

[Moc]

I see this is your own theme. Does it use a custom news template? If yes, can you share that news template code with me please? You can send it by email or on Gitter.

[Moc]

@fizi can you please give me some feedback on this? :) What is the shortcode that is used to display the text that you circled in your screenshot?

[fizi]

I use {NEWSCOMMENTS} shortcode.

[Moc]

@fizi I cannot reproduce this at all. The {NEWSCOMMENTS} will output ''Disabled" when the comments are disabled. I do not see why it would output "Comments are turned off for this item" in that place.

What are your settings for:

• "Allow users to post comments" in the Comments manager.
• News item "Free theme - BS Gaming 03" > Advanced options > Comments

[Moc]

@fizi Do you still experience this issue with the latest files?

[Moc]

Reminder: add pref to enable/disable showing the comments locked message. Or debug message? Admin only?

[Jimmi08]

@Moc
for pages there is no scenario when you want to displays this message. Either it is standalone page and you don't want comments at all or you want comments and you set them on.

It is something different than for news.

So part solution is changing only cpagecomments() for now.

	// Not a shortcode really, as it shouldn't be cached at all :/
	function cpagecomments()
	{
		$com 		= $this->var['comments'];
		$comflag 	= $this->var['page_comment_flag'];
 
		//if($parm && isset($com[$parm])) return $com[$parm];
		if($comflag)
		{
			return e107::getComment()->parseLayout($com['comment'],$com['comment_form'],$com['moderate']);	
		}
        else return '';
		
	//	return $com['comment'].$com['moderate'].$com['comment_form'];
	}

[Moc]

Reminder for myself. Make this a debug message.

[Moc]

Reminder: add pref to enable/disable showing the comments locked message. Or debug message? Admin only?

Changed the message to a debug message which is shown to admins only.

I think this issue can now be closed. Please let me know if there are any questions or suggestions related to this issue.

@fizi If you can still reproduce the issue you posted in your screenshot, let me know and I'll figure it out.

[Jimmi08]

@Moc Why don't you test e_DEBUG? It is annoying for admins too...

[Moc]

It should only display when debug mode is enabled (because of e107::getMessage()->addDebug()).

It may occur on non-bootstrap themes though, you have point there.

[Moc]

Done

[Jimmi08]

@Moc
Could you or somebody check/test condition in function cpagecomments() ?

there is code for comments off:

if(e107::getPref('comments_disabled') == 0 && !$comflag)

but comment_class uses (for not to display comment form)

		if(isset($pref['comments_disabled']) && $pref['comments_disabled'] == TRUE)
		{
			
        	return FALSE;
		}

It could be confusing because comment manager uses this in inverse way...

That shortcode should maybe look like this:

	function cpagecomments()
	{
		$com 		= $this->var['comments'];
		$comflag 	= $this->var['page_comment_flag'];
 
        if(isset(e107::getPref('comments_disabled')) && e107::getPref('comments_disabled') == TRUE) {
            return '';
        }
 
		if($comflag)
		{
			return e107::getComment()->parseLayout($com['comment'],$com['comment_form'],$com['moderate']);	
		}
        else {
        
            if(ADMIN && deftrue('e_DEBUG'))
  			{
  				if(defined('BOOTSTRAP') && BOOTSTRAP)
  				{
  					return e107::getMessage()->addDebug(LAN_PAGE_17)->render(); 
  				}
  				else
  				{
  					return "<br /><div style='text-align:center'><b>".LAN_PAGE_17."</b></div>";
  				}
  			}
        }
		
	//	return $com['comment'].$com['moderate'].$com['comment_form'];
	}

Or like with news (there is different logic/order of checks)

// Only show message if global comments are enabled, but current news item comments are disabled
if(e107::getPref('comments_disabled') == 0 && $news['news_allow_comments'] == 1)