Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sitecontactinfo and contact form have the same style ID #3684

Closed
Jimmi08 opened this issue Feb 20, 2019 · 7 comments
Closed

sitecontactinfo and contact form have the same style ID #3684

Jimmi08 opened this issue Feb 20, 2019 · 7 comments
Assignees
Labels
Help Wanted type: enhancement An improvement or new feature request
Milestone

Comments

@Jimmi08
Copy link
Contributor

Jimmi08 commented Feb 20, 2019

image

$ns -> tablerender(LANCONTACT_01, $text,"contact");
$ns -> tablerender(LANCONTACT_02, $text, "contact");

could it be changed to contact-info ?
they use already different templates

$CONTACT_TEMPLATE['info']
$CONTACT_WRAPPER['form']

Thanks

@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Feb 20, 2019

Tablerender about successful email has no id:
At least "contact" would be nice.
$ns->tablerender('', "<div class='alert alert-success'>".$message."</div>");

@Moc Moc added the type: enhancement An improvement or new feature request label Feb 21, 2019
@Moc Moc added this to the Future milestone Feb 21, 2019
@Moc
Copy link
Member

Moc commented Feb 21, 2019

#2980

@Moc
Copy link
Member

Moc commented Feb 21, 2019

@fizi @Jimmi08

@CaMer0n and I were thinking to use three new ID's: contact-info, contact-form, contact-menu. This may some break existing themes but it will increase consistency and allow styling for all areas. What do you think?

@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Feb 21, 2019

It would be great if it has some logic :
plugin and template key
yes, that suggestion is ok. And yes, it will break some themes, but it can be easily fixed. There should be a list of what to check when you update.

@fizi
Copy link

fizi commented Feb 21, 2019

I agree with Jimmi08.

@CaMer0n
Copy link
Member

CaMer0n commented Feb 21, 2019

Thank you @Jimmi08 @fizi .

Yes, I believe the correct logic for the render ID would be template name and template key.

ie.

$CONTACT_TEMPLATE['menu'] = contact-menu
$FORUM_VIEWTOPIC_TEMPLATE['replies']  = forum-viewtopic-replies

@Moc Moc self-assigned this Mar 3, 2019
@Moc Moc added the Help Wanted label Mar 4, 2019
Moc added a commit that referenced this issue Sep 17, 2019
Create consistency (template name and template key)

e.g.
$CONTACT_TEMPLATE['menu'] = contact-menu
$FORUM_VIEWTOPIC_TEMPLATE['replies']  = forum-viewtopic-replies
@Moc
Copy link
Member

Moc commented Sep 17, 2019

Updated contact.php. If you come across other inconsistencies then please list them here

@Moc Moc closed this as completed Sep 17, 2019
@Moc Moc modified the milestones: Future, e107 2.2.2 Sep 17, 2019
@Moc Moc moved this to Backlog in Documentation update Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted type: enhancement An improvement or new feature request
Projects
Status: Backlog
Development

No branches or pull requests

4 participants