Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avatar thumbnails in wrong aspect ratio after update #3721

Closed
realG opened this issue Mar 9, 2019 · 6 comments
Closed

avatar thumbnails in wrong aspect ratio after update #3721

realG opened this issue Mar 9, 2019 · 6 comments
Labels
status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing.
Milestone

Comments

@realG
Copy link

realG commented Mar 9, 2019

Hi everyone, can you please help me troubleshoot this issue?

I was massively behind with my e107 code so did a git pull today from the master branch and after a few tweaks and a db update it all seems to be working, except the thumbnails of user avatars (in chatbox, user profile page, etc) are now shown in a square aspect ratio so look a bit distorted.

Tried clearing the cache through the admin pages and the browser cache. I'm using a very lightly modified bootstrap3 theme, I also tried switching to the clean bootstrap3 theme shipped with e107 but that doesn't make a difference so it's probably not theme-related. I'm on Ubuntu 18.04, nginx + php 7.2 with GD2 if that matters.

The html I end up with (this is from the member profile page) looks like this:
<img class="img-circle user-avatar" alt="avatar.jpg" src="/thumb.php?src=avatar.jpg&w=200&h=200" width="200" height="200">

Please help :)

@Moc
Copy link
Member

Moc commented Mar 10, 2019

Very interesting.. the css class still shows correct as 'img-circle' but apparently the image is rendered as square instead.

Can you please verify that the bootstrap.css version that is loaded is 3.x? and not 4.x?

@Moc Moc added the status: awaiting feedback This issue may be fixed and is awaiting the original poster to confirm the fix. label Mar 10, 2019
@realG
Copy link
Author

realG commented Mar 10, 2019

Yes it appears to be, inspecting one of the thumbnails in Chrome the bootstrap.css that's loaded points to 3.3.6

@Moc Moc added status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. and removed status: awaiting feedback This issue may be fixed and is awaiting the original poster to confirm the fix. labels Mar 11, 2019
@Moc
Copy link
Member

Moc commented Mar 11, 2019

Interesting, then I have no idea what is causing this.

@CaMer0n Any thoughts?

@CaMer0n
Copy link
Member

CaMer0n commented Mar 11, 2019

@Moc I'd need to see the actual page. @realG Can you post a URL?

@realG
Copy link
Author

realG commented Mar 12, 2019

Hm that might be difficult it's currently not accessible from outside my network... I'll see if I can spin up a sanitised copy that I could make accessible online. In the meantime please let me know if you can think of any other place in css or the code I could look at to debug what's going on.

@CaMer0n CaMer0n added this to the e107 2.2.0 milestone May 16, 2019
CaMer0n added a commit that referenced this issue May 16, 2019
@CaMer0n CaMer0n modified the milestones: e107 2.2.0, e107 2.2.1 May 18, 2019
@CaMer0n
Copy link
Member

CaMer0n commented May 27, 2019

Closing, as the added crop support should fix it. Please re-open if necessary.

@CaMer0n CaMer0n closed this as completed May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing.
Projects
None yet
Development

No branches or pull requests

3 participants