Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forum templating - probably ranks ? #3827

Closed
Jimmi08 opened this issue Jun 5, 2019 · 4 comments
Closed

forum templating - probably ranks ? #3827

Jimmi08 opened this issue Jun 5, 2019 · 4 comments
Assignees
Labels
plugin: forum type: bug A problem that should not be happening
Milestone

Comments

@Jimmi08
Copy link
Contributor

Jimmi08 commented Jun 5, 2019

Sorry, I haven't time to look from where is this now, but there is some shortcode what output empty HTML code.
PS. I am trying to avoid custom theme template.

If the value is empty, it should return nothing or there should be some default value (f.e. user, quest) so there would be always something displayed.

image

@Moc Moc self-assigned this Jun 5, 2019
@Moc Moc added type: bug A problem that should not be happening type: enhancement An improvement or new feature request plugin: forum labels Jun 5, 2019
@CaMer0n
Copy link
Member

CaMer0n commented Jun 11, 2019

Yes, if there is no value is should return null, so that shortcode wrappers can know not to render.

@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Jun 11, 2019

so that shortcode wrappers can know not to render.

Correct. The problem is that wrappers render something or it doesn't return null. There is reductant html code, but tag.

@Moc
Copy link
Member

Moc commented Jul 2, 2019

Wasn't able to reproduce on a test install, but added a fix which which may help.
@Jimmi08 When you have time, can you check to see if this solves the issue?

@Moc Moc removed the type: enhancement An improvement or new feature request label Jul 2, 2019
@Moc Moc added this to the e107 2.2.2 milestone Jul 2, 2019
@Moc Moc added the status: awaiting feedback This issue may be fixed and is awaiting the original poster to confirm the fix. label Jul 2, 2019
@Moc Moc modified the milestone: e107 2.2.2 Jul 2, 2019
@Moc Moc removed the status: awaiting feedback This issue may be fixed and is awaiting the original poster to confirm the fix. label Jul 2, 2019
@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Jul 2, 2019

Solved. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: forum type: bug A problem that should not be happening
Projects
None yet
Development

No branches or pull requests

3 participants