Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alt_auth plugin - using e107 as secondary authorisation causes blank page + FIX #3983

Closed
Jimmi08 opened this issue Oct 26, 2019 · 3 comments · Fixed by #4864
Closed

alt_auth plugin - using e107 as secondary authorisation causes blank page + FIX #3983

Jimmi08 opened this issue Oct 26, 2019 · 3 comments · Fixed by #4864
Labels
plugin: alt_auth status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing.

Comments

@Jimmi08
Copy link
Contributor

Jimmi08 commented Oct 26, 2019

If primary authorisation fails, e107 causes blank page

image

Reason for this is that method value is e107db and not e107 like is done in this test:
in handlers/login.php

if ($method == 'e107' )

this fixed it:

if ($method == 'e107' OR $method == 'e107db')

@Moc Moc added status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing. plugin: alt_auth labels Oct 27, 2019
@Jimmi08 Jimmi08 changed the title alt_auth plugin - using e107 as secondary authorisation causes blank page alt_auth plugin - using e107 as secondary authorisation causes blank page + FIX Oct 29, 2019
@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Dec 29, 2019

This shouldn't be closed.

I am trying to get how this should work.

e107 - is your actual e107 installation
e107db - is other e107 installation.

You can't now select e107 as a secondary installation.
image

That second PR was solving this, but it wasn't merged and after rebase it's not there anywhere.

@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Mar 27, 2021

@CaMer0n @Moc
What is planned or what was the intention when you want to use your actual e107 as a secondary authorization type?

for example, there is used:

	if($pref['auth_nouser'])
	{
		$cfg->set('auth_method2', 'e107');
	}
 

but dropdown values for auth_method2 field are:

<option value="none">none</option>
<option value="e107db">e107db</option>
<option value="importdb">importdb</option>
<option value="ldap">ldap</option>
<option value="otherdb" selected="selected">otherdb</option>
<option value="radius">radius</option>

And fix was:
<td>".$altAuthAdmin->alt_auth_get_dropdown('auth_method2', $pref['auth_method2'], 'none,e107')."

Thanks

@CaMer0n
Copy link
Member

CaMer0n commented Apr 6, 2021

@Jimmi08 Pull-request welcome. Nothing planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: alt_auth status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants