Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

media manager - url value for files #4049

Closed
Jimmi08 opened this issue Dec 18, 2019 · 3 comments
Closed

media manager - url value for files #4049

Jimmi08 opened this issue Dec 18, 2019 · 3 comments
Labels
core: media manager type: bug A problem that should not be happening type: enhancement An improvement or new feature request
Milestone
e107 2.3.0

Comments

@Jimmi08
Copy link
Contributor

Jimmi08 commented Dec 18, 2019

If your path for files (download files or manual upload files, not images) has value {e_MEDIA_FILE},
then URL field displays the wrong value.

thumb.php?src=e_MEDIA_FILE%2F2019-12%2Ffilename.pdf&w=800&h=0

with path {e_MEDIA_IMAGE} , URL value is correct (pretty URL for image)
Maybe is better doesn't display anything that this. It's confusing. For example, with zip file result ends with
https://placehold.it/800x0
but with pdf, you get error File is not a valid image, but displayed URL is correct.
File is not a valid image: e107_media/***/files/2019-12/filename.pdf
@Jimmi08 Jimmi08 changed the title media manager - url value for not pdf file media manager - url value for files Dec 18, 2019
@Moc Moc added core: media manager type: enhancement An improvement or new feature request labels Jan 2, 2020
@CaMer0n CaMer0n added the type: bug A problem that should not be happening label Feb 21, 2020
@CaMer0n CaMer0n added this to the e107 2.3.0 milestone Feb 21, 2020
CaMer0n added a commit that referenced this issue Feb 21, 2020
@CaMer0n
Issue #4049 - Media-Manager Url fix. Fixed Media Preview.
79c5b3e 
Admin-ui: type='media' example added to blank plugin.
@Moc
Copy link
Member

Moc commented May 23, 2020

What's the status on this one?

@Jimmi08
Copy link
Contributor Author

Jimmi08 commented May 23, 2020

@Moc No change

CaMer0n added a commit that referenced this issue May 25, 2020
@CaMer0n
Issue #4049 - media_sef (URL) returned for media type 'file' was inco…
2009549 
…rrect.
@CaMer0n
Copy link
Member

CaMer0n commented May 25, 2020

@Jimmi08 Please try now. (check the media-type value in the database is correct)

@CaMer0n CaMer0n closed this as completed Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core: media manager type: bug A problem that should not be happening type: enhancement An improvement or new feature request
Projects
None yet
Milestone
e107 2.3.0
Development

No branches or pull requests
3 participants
@Moc @CaMer0n @Jimmi08