handler dependent on social plugin

[nesjett]

e107/e107_handlers/user_handler.php

Line 1113 in 94dbbb0

require_once(e_PLUGIN . "social/includes/social_login_config.php");

This line requires a file from social plugin. This means that even if you are not using this plugin, you cannot delete it from the plugins folder or the system will crash.

Error shown when deleting social plugin:

Fatal error: require_once(): Failed opening required '../e107_plugins/social/includes/social_login_config.php' (include_path='.;C:/*/php/pear') in C:*\e107_handlers\user_handler.php on line 1113

[Jimmi08]

#1379

[Deltik]

Easiest way to fix this would be to move ./e107_plugins/social/includes/social_login_config.php into the core somewhere, but I'm not sure where.

[Moc]

@Deltik A new social login handler in e107_handlers?

[Deltik]

Yes, moving that class social_login_config to e107_handlers makes sense.

[Deltik]

Never mind. Upon reviewing the code I wrote, I violated the Law of Demeter by making social_login_config aware of Hybridauth when it should only be working with an e_pref. I'll try to decouple these things in my fix.