Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newscats{active} - shouldn't be {active} replaced by something? #4206

Closed
Jimmi08 opened this issue Jun 29, 2020 · 2 comments
Closed

newscats{active} - shouldn't be {active} replaced by something? #4206

Jimmi08 opened this issue Jun 29, 2020 · 2 comments
Labels
type: bug A problem that should not be happening type: question An ask about behavior that is not found documented anywhere
Milestone

Comments

@Jimmi08
Copy link
Contributor

Jimmi08 commented Jun 29, 2020

Question

Is this correct? In category news menu.

image

Core template:

// category menu
$NEWS_MENU_TEMPLATE['category']['start']       = '<ul class="news-menu-category">';
$NEWS_MENU_TEMPLATE['category']['end']         = '</ul>';
$NEWS_MENU_TEMPLATE['category']['item']        = '
	<li><a class="e-menu-link newscats{active}" href="{NEWS_CATEGORY_URL}">{NEWS_CATEGORY_TITLE}{NEWS_CATEGORY_NEWS_COUNT}</a></li>
';

Thanks

@Jimmi08 Jimmi08 added the type: question An ask about behavior that is not found documented anywhere label Jun 29, 2020
@CaMer0n CaMer0n added the type: bug A problem that should not be happening label Jul 3, 2020
@CaMer0n CaMer0n added this to the e107 2.3.0 milestone Jul 3, 2020
@CaMer0n
Copy link
Member

CaMer0n commented Jul 3, 2020

@Jimmi08 Please give this change a test drive.
{active} should be replaced with {ACTIVE} in your theme's template.

@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Jul 4, 2020

It works, Thank you.

@Jimmi08 Jimmi08 closed this as completed Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A problem that should not be happening type: question An ask about behavior that is not found documented anywhere
Projects
None yet
Development

No branches or pull requests

2 participants