backup option doesn't backup database

[Jimmi08]

Bug Description

e107 is not able to backup database on live server

This is localhost:

This is live site:

As you can see SQL file is not created.

Live site:
PHP Version 5.6.40
10.1.38-MariaDB-1~xenial
PDO: Enabled
NO_ENGINE_SUBSTITUTION

Version 2.3.0 (git)

Admin log:

[Jimmi08]

Reason:
This
$dump = new Ifsnop\Mysqldump\Mysqldump('mysql:host='.$config['mySQLserver'].';dbname='.$config['mySQLdefaultdb'], $config['mySQLuser'], $config['mySQLpassword'], $dumpSettings);

return error:

mysqldump-php error: Connection to mysql failed with message: SQLSTATE[HY000] [2005] Unknown MySQL server host 'mariadb101.websupport.sk:3312' (2)

but correct connection according my hosting should be:

$connection = new PDO("mysql:host=mariadb101.websupport.sk;port=3312;dbname=****", "****", "***");

After hardcoded those 2 values, backup was created:
'mysql:host=mariadb101.websupport.sk;port=3312;dbname=

[Jimmi08]

This was solved this way before:

		if(strpos($mySQLserver,':')!==false && substr_count($mySQLserver, ':')===1)
		{
			list($this->mySQLserver,$this->mySQLport) = explode(':',$mySQLserver,2);
		}

2420c97

[Moc]

@Deltik do we need to apply the same fix to the pdo handler?

[Jimmi08]

@Moc just for backup, connect() works this way. At least I hope and it didn't fall back to mysql connect.

[Deltik]

@Moc: No, the hostname and port are already parsed by the time e_db_pdo::backup() is called. This patch should fix the issue:

diff --git a/e107_handlers/e_db_pdo_class.php b/e107_handlers/e_db_pdo_class.php
index 1e73bf01b..511f45690 100644
--- a/e107_handlers/e_db_pdo_class.php
+++ b/e107_handlers/e_db_pdo_class.php
@@ -2455,8 +2455,6 @@ class e_db_pdo implements e_db
 
    //     include_once(dirname(__FILE__) . '/Ifsnop/Mysqldump/Mysqldump.php');
 
-        $config = e107::getMySQLConfig();
-
                $dumpSettings = array(
                'compress'                      => !empty($options['gzip']) ? Ifsnop\Mysqldump\Mysqldump::GZIP : Ifsnop\Mysqldump\Mysqldump::NONE,
                'include-tables'                => array(),
@@ -2477,13 +2475,13 @@ class e_db_pdo implements e_db
 
         foreach($tableList as $tab)
         {
-            $dumpSettings['include-tables'][] = $config['mySQLprefix'].trim($tab);
+            $dumpSettings['include-tables'][] = $this->mySQLPrefix.trim($tab);
         }
 
 
         try
         {
-            $dump = new Ifsnop\Mysqldump\Mysqldump('mysql:host='.$config['mySQLserver'].';dbname='.$config['mySQLdefaultdb'], $config['mySQLuser'], $config['mySQLpassword'], $dumpSettings);
+            $dump = new Ifsnop\Mysqldump\Mysqldump("mysql:host={$this->mySQLserver};port={$this->mySQLport};dbname={$this->mySQLdefaultdb}", $this->mySQLuser, $this->mySQLpassword, $dumpSettings);
                    $dump->start($backupFile);
                    return $backupFile;
                }

@Jimmi08: Can you try this patch to see if it works for your setup with the custom hostname and port?

[Jimmi08]

@Deltik I am getting error:
mysqldump-php error: Missing database name from DSN string

This version works (I just replaced $config), but I have no idea what is wrong/different with yours (I checked it, string is correct, db is there):
$dump = new Ifsnop\Mysqldump\Mysqldump('mysql:host='.$this->mySQLserver.';port='.$this->mySQLport.';dbname='.$this->mySQLdefaultdb, $this->mySQLuser, $this->mySQLpassword, $dumpSettings);

[Deltik]

@Jimmi08: Sorry, I had some extraneous spacing in the DSN string. Here's the updated patch. I tested it myself this time, and the data got exported as expected.