Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e_form::get_attributes() should not escape the "other" case #4572

Closed
Deltik opened this issue Sep 23, 2021 · 0 comments · Fixed by #4573
Closed

e_form::get_attributes() should not escape the "other" case #4572

Deltik opened this issue Sep 23, 2021 · 0 comments · Fixed by #4573

Comments

@Deltik
Copy link
Member

Deltik commented Sep 23, 2021

@Deltik This commit introduced a bug into the form handler.

git.exe bisect good
2088292 is the first bad commit
commit 2088292
Author: Nick Liu
Date: Sat Sep 4 15:06:19 2021 +0200

Specifically it renders the following invalid HTML in the batch options and elsewhere.

I previously committed a fix for the pop-up confirmation on the admin area cache delete button, which had a similar issue. ( 632f335)

It appears the parsing of the $options['other'] value has been corrupted (see quick-fix commit above)

<select name="etrigger_batch" id="etrigger-batch" class="tbox form-control input-large select batch e-autosubmit reset" data-original-title="" title="">
<option value="">With selected...</option>
<option value="copy" class="ui-batch-option class" style="&quot;padding-left:" 15px&quot;="">Copy</option>
<option value="delete" class="ui-batch-option class" style="&quot;padding-left:" 15px&quot;="">Delete</option>
<option value="export" class="ui-batch-option class" style="&quot;padding-left:" 15px&quot;="">Export</option>	

Originally posted by @CaMer0n in #4554 (comment)

Deltik added a commit to Deltik/e107 that referenced this issue Sep 23, 2021
CaMer0n added a commit that referenced this issue Sep 23, 2021
#4572: `e_form`: No `htmlspecialchars()` on "other" attributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant