access / check for access to forum type in forum post

[Jimmi08]

Bug Description

There are different checks or wrong check.

I have imported forums (not created manually). It happened that forum moderator was set to contact class.
As the main admin, I don't have this class, so I shouldn't be forum moderator.

I added new sticky topic. Type wasn't save. It is because this:

$threadVals['thread_sticky'] = (MODERATOR ? (int)$_POST['threadtype'] : 0);

It is correct, I checked value of MODERATOR constant and it was false, so my settings was ignored. As soon as I switched moderator class, it worked.

But why I can see this setting if I am not moderator?

There is this check:
if (deftrue('MODERATOR') && $this->var['action'] == "nt" || varset($this->var['thread_datestamp']) == $this->var['post_datestamp'])

With this :

        var_dump(deftrue('MODERATOR'));
        var_dump($this->var['action']);
        var_dump($this->var['thread_datestamp']);
        var_dump($this->var['post_datestamp']);

Values are
For new topic:

• string(0) ""
• string(2) "nt"
• NULL
• NULL

For edit topic:
string(0) ""
string(4) "edit"
string(10) "1642246300"
string(10) "1642246300"

I think that check should be:

if (deftrue('MODERATOR') && ($this->var['action'] == "nt" || varset($this->var['thread_datestamp']) == $this->var['post_datestamp']))

Thanks