Fix for displaying multiple comment forms on the same page #1945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the use of IDs in order of Classes as identifiers, the comment form was not able to work properly. NOTE: Next and Prev buttons doesnt work, but I think its not related to this issue. Please, confirm that they are not working on the e107 previous this commit.
|
Fix related to #1944 |
nesjett
changed the title
lonalore
reviewed
Oct 19, 2016
| @@ -80,12 +80,15 @@ $(document).ready(function() | |||
|
|
|||
| $(document).on("click", ".e-comment-submit", function(){ | |||
|
|
|||
| var commentsParent = $(this).parent().parent().parent().parent().parent().parent().parent(); | |||
There was a problem hiding this comment.
This won't work if you use custom templates for comments, because the HTML structure may be not the same. Use parents() instead. For example if you want to get the form, which contains your element, use something like this:
var $form = $(this).parents('form:first');
|
Closing this as the proposed changes would break as per the comments mentioned above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the use of IDs in order of Classes as identifiers, the comment
form was not able to work properly.
NOTE: Next and Prev buttons doesnt work, but I think its not related to
this issue. Please, confirm that they are not working on the e107
previous this commit.