Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forum userlist shortcode wrapping #2065

Closed

Conversation

rica-carv
Copy link
Contributor

Removed hardcoded html and use wrapping instead, for userlist shortcode...

Removed hardcoded html and use wrapping instead, for userlist shortcode...
@CaMer0n
Copy link
Member

CaMer0n commented Nov 25, 2016

Thanks. Tested with bootstrap3 already?

@rica-carv
Copy link
Contributor Author

@CaMer0n I've tested already in bootsrtap3 theme, and it works, but it seems that the {USERLIST} shortcode is only used in old legacy themes (anyway, i'm personally using it on a bootstrap theme of my own.... 😉 ), so i'm on a dillema:
Should it use the new wrapper mode or the legacy wrap mode?

@CaMer0n
Copy link
Member

CaMer0n commented Nov 26, 2016

This will break for anyone using a pre v2.x template with this forum shortcode. Why don't you just create a new one called USERLISTX ?

@rica-carv
Copy link
Contributor Author

I've tested it with jayya, and the break seems to be not my changes, but the attempt to load theme_shortcodes from the jayya theme:

Couldn't Load: e107_themes/jayya/theme_shortcodes.php with class-name: theme_shortcodes and pluginName
Function: 	e_parse_shortcode->getScObject()()
File: 	G:\PortableApps\UniServerZ\www\e107-master\e107_handlers\e107_class.php
Line: 	1125

Anyway, i could do the extra shortcode, but it would simply duplicate code from the legacy shortcode....

@CaMer0n CaMer0n closed this Mar 2, 2021
@rica-carv rica-carv deleted the rica-carv-forum_userlist_wrapping branch June 24, 2024 20:01
@rica-carv rica-carv restored the rica-carv-forum_userlist_wrapping branch August 3, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants