Error page improvement: template support. And status code support for e107::redirect(). #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lonalore
commented
Dec 14, 2016
•
lonalore
commented
|
This looks great. Much needed code clean-up. Thanks @lonalore |
|
Beautiful work (as usual) ! Thank you! 👍 |
|
Thank you! But it is not yet finished. :) I would like to add a method (e.g. e107::setErrorPage()), which can be used for delivering error page contents to the browser directly, without redirect. It would be great for plugin developers to use system error pages in their custom plugins. But I'll need some help from @CaMer0n ... :) I'll send you a message on Gitter. |
|
okay! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.