PHP 8.0 compatibility

[Deltik]

Motivation and Context

PHP 8.0 is now stable and released, but e107 won't run on it because of various syntax and logic errors.

Description

This pull request fixes all PHP 8.0 errors caught by the existing tests. Specifically:

Vendor Changes

• tedivm/jshrink appears to be abandoned and times out while minifying any JavaScript. It has been replaced with matthiasmullie/minify, which seems to be a drop-in replacement.
• The test framework is no longer pinned to PHP 5.6 to enable phpunit/phpunit to run on PHP 8.0.

Method Signatures

• error_handler::handle_error() had a required fifth parameter, but set_error_handler() in PHP 8.0 only sends four arguments.
• lancheck::check_lanfiles() had a required parameter after the optional parameters, which is a compile error in PHP 8.0.
• lancheck::checkLog() had a required parameter after the optional parameters, which is a compile error in PHP 8.0.
• The sitelinks_alt class had methods called statically without the methods being declared as static, but PHP 8.0 now requires static methods to be declared as such.
• e107::getTemplateInfo() had a required parameter after the optional parameters, which is a compile error in PHP 8.0. The first parameter, $plug_name, must be provided now, even if it is null.
• e_marketplace::getDownloadModal() had a required parameter after the optional parameters, which is a compile error in PHP 8.0.
• themeHandler::renderTheme() had a required parameter after the optional parameters, which is a compile error in PHP 8.0.
• e107forum::set_crumb() had a required parameter after the optional parameters, which is a compile error in PHP 8.0.

Variables and Constants

• The BOOTSTRAP constant was sometimes referenced before being defined.
• siteStats::renderTodaysVisits() tried to increment a number by a string, which is not possible in PHP 8.0.
• siteStats::bar() tried to number_format() a string, which is not possible in PHP 8.0.
• The USER_WIDTH constant may have been referenced before being defined.

Function Changes

• In PHP 8.0, the built-in function \get_parent_class() now raises an Error if it is provided a string that does not represent a class, but to maintain compatibility with PHP 5.6, a shim is required to suppress the Error.

Logic Changes

• e_form::option_multi() performed a weak equality check on which value is selected, but PHP 8.0 reworked their string to number comparisons, which makes the output different. The comparison is now strict to enforce consistent output.
• user_class::getName() performed a weak comparison on the input parameter, which could be provided as an empty string instead of a number. Since PHP 8.0 reworked their string to number comparisons, the comparison in this method is now made consistent by casting the input to an int.

How Has This Been Tested?

The changes make the existing tests pass on all PHP major versions since version 5.6. The GitHub Actions automated testing has been expanded to test on PHP 5.6 through PHP 8.0 on MySQL 5.5 through MySQL 8.0 and MariaDB 10.0 through MariaDB 10.5.

Types of Changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Performance enhancement (non-breaking change which improves efficiency)
• Code cleanup (non-breaking change which makes code smaller or more readable)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation (a change to man pages or other documentation)

Checklist

• My code adheres to the e107 code style standard.
• I have read the contributing document.
• I have added tests to cover my changes.
• All new and existing tests pass.

[codeclimate]

Code Climate has analyzed commit 28ae487 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 20.9% (80% is the threshold).

This pull request will bring the total coverage in the repository to 8.4% (0.0% change).

View more on Code Climate.