Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4724 forum - possibility to add forum ID as column #4725

Closed
wants to merge 3 commits into from
Closed

#4724 forum - possibility to add forum ID as column #4725

wants to merge 3 commits into from

Conversation

Jimmi08
Copy link
Contributor

@Jimmi08 Jimmi08 commented Mar 29, 2022

Closes #4724

Jimmi08 added 3 commits March 29, 2022 11:20
@Jimmi08
#4724 forum - possibility to add forum ID as column
c9e06e9 
Closes #4724
@Jimmi08
#4659 forum main admin as silent moderator
e3c7c99 
- without displaying in moderator list (if they are not forum moderators directly)

CLOSES #4659
@Jimmi08
fix for forum modal attachment in bootstrap5
4053fe3 
CLOSES #4726
with bootstrap5 forum attachment image are not opened in modal
@CaMer0n
Copy link
Member

CaMer0n commented Mar 29, 2022

This commit doesn't provide "possibility to add forum ID as column" it forces the ID to be visible at all times. Also the PR contains other unrelated changes. 'type'=>'number' would be more appropriate. Please resubmit.

@CaMer0n CaMer0n closed this Mar 29, 2022
@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Mar 29, 2022

Thanks, I didn't know about this option.

Sorry, it somehow combined other PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

forum - possibility to add forum ID as column
2 participants
@Jimmi08 @CaMer0n