Forum iconkey templatization #5316
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aditional check for external linked avatars. Without the code, external linked avatars not available are shown without the default avatar
Changed file_exists to fopen, to check if remote file exists
Aditional change to make default avatar image render
Add files via upload
…runcate Revert "Add files via upload"
|
Code Climate has analyzed commit b2cbe78 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 38.9% (0.3% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forum iconkey templatization
Motivation and Context
Forum iconkey templatization, to allow full theme level templatization of the iconkey, just like there's already in viewfourm template
Description
Retained legacy code
How Has This Been Tested?
Testen in v 2.3.3
Types of Changes
Checklist