-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
newforumpostsmenu update #5340
Open
rica-carv
wants to merge
17
commits into
e107inc:master
Choose a base branch
from
rica-carv:rica-carv-newforumpostsmenu
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
newforumpostsmenu update #5340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aditional check for external linked avatars. Without the code, external linked avatars not available are shown without the default avatar
Changed file_exists to fopen, to check if remote file exists
Aditional change to make default avatar image render
Add files via upload
…runcate Revert "Add files via upload"
Fixes e107inc#5317 - Missing ID in creation log.
Updated newforumposts_menu to full page render
Minor bug correction and update Still work in progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Allow newforumposts_menu to be rendered in full page, as original code. Fixes issue #4322 and discussion #5337
And yes, you can force the output of menus in pages with the {MENU} shortcode in templates.
Description
Updated code
How Has This Been Tested?
It can now even allow in the same page to be shown as page and menu with diferent layouts options
Right side is a regular menu rendered in the menu area, the left side is a custom page with the same menu rendered via the {MENU} shortcode.
See example here
Types of Changes
Checklist