Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forum shortcode e_BASE bug correction #5347

Merged
merged 15 commits into from
Jan 10, 2025
Merged

Forum shortcode e_BASE bug correction #5347

merged 15 commits into from
Jan 10, 2025

Conversation

rica-carv
Copy link
Contributor

@rica-carv rica-carv commented Oct 6, 2024 •
edited
Loading

Motivation and Context

Bug correction. e_BASE gives the path to the full plugin folder from where it's used. Switching to e_HTTP, since online.php is on the root...
Furthermore, shouldn't these URL be SEF? How can it be donne, since the files are on the root?

Description

Switched e_BASE for e_HTTP

How Has This Been Tested?

Tested in v2.3.3

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist

rica-carv and others added 15 commits April 27, 2024 12:57
@rica-carv
Aditional check for external missing avatars
65fc765 
Aditional check for external linked avatars.
Without the code, external linked avatars not available are shown without the default avatar
@rica-carv
Add files via upload
cc41528
@rica-carv
Update e_parse_class.php
bcaad61 
Changed file_exists to fopen, to check if remote file exists
@rica-carv
Merge branch 'e107inc:master' into master
591bab9
@rica-carv
Aditional change to make default avatar image render
9128256 
Aditional change to make default avatar image render
@rica-carv
Add files via upload
9c156d4
@rica-carv
Merge pull request #56 from rica-carv/rica-carv-patch-texttruncate
c8483ad 
Add files via upload
@rica-carv
Revert "Add files via upload"
3de1ea4
@rica-carv
Merge pull request #57 from rica-carv/revert-56-rica-carv-patch-textt…
6a7eeb0 
…runcate

Revert "Add files via upload"
@rica-carv
Merge pull request #59 from e107inc/master
253ace4 
.
@rica-carv
Delete e107_handlers/e_parse_class.php
88e7261
@rica-carv
Add files via upload
9fa6f1a
@CaMer0n @rica-carv
Fixes e107inc#5317 - Missing ID in creation log.
2a65f8b
@rica-carv
Merge pull request #61 from e107inc/master
788ae6a 
Fixes e107inc#5317 - Missing ID in creation log.
@rica-carv
Update forum_shortcodes.php
8d2e28c 
Bug correction. e_BASE gives the path to the full plugin folder from where it's used. Switching to e_HTTP, since online.php is on the root...
@CaMer0n CaMer0n added this to the e107 2.4.0 milestone Jan 10, 2025
@CaMer0n CaMer0n merged commit f98d386 into e107inc:master Jan 10, 2025
1 of 23 checks passed
@CaMer0n
Copy link
Member

CaMer0n commented Jan 10, 2025

Thank you @rica-carv !

@rica-carv rica-carv deleted the rica-carv-forum_shortcode_bug branch January 11, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
e107 2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rica-carv @CaMer0n