Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button function customization #5397

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

rica-carv
Copy link
Contributor

Motivation and Context

Added customization to enable tooltips on buttons and custom classes inside the dropdown lists

Description

Added the support to tags attributes

How Has This Been Tested?

Tested in latest github code

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist

@rica-carv
Copy link
Contributor Author

rica-carv commented Jan 17, 2025

Personally i think this function could benefit from using templates, since it would give the flexibility to be rendered as one of the three possible HTML tags, as stated in the BS docs, with the same styling plugin wide or theme wide...

Probably the overhead of adding a template parsing to this function is too much...
What would be better?

  • Have multiple calls to the function as it is right now with all the default styling classes, etc, scattered in a plugin/theme hardcoded in the PHP code, and hard to customize everytime i call the function?
    Imagine a theme designer change all this code in a theme....
  • Or have the HTML styled in single location easy to customize in my plugin/theme in a template?

But it's just my thougths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant