Fix for #819 #1126
Closed
Fix for #819 #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't use displayName in activities descriptions if it's a 0-length string
jankusanagi
changed the title
Updated front page and welcome message with useful links
|
@jankusanagi can you rebase this on top of current |
Add Contributor Covenant
For client javascript code written by E14N add stylized comments around license notice. For 3rd party code verbatim copied from other projects create JavaScript Web Labels table and keep scripts code unchanged.
We can not be sure that other inlined javascript code is free
Support librejs browser plugin.
…{headless: false}. So add missing {
Add missing { to a dictionary definition
only iterate over replies.items if it exists.
…gi/pump.io-jan into fix-empty-object-names
|
I think I messed this up :p |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple fix for #819. It can probably be made in a more elegant way, but this one seems to work well.
It just checks that the string in 'displayName' is not empty, because if it is, activities descriptions regarding the "null-named" object get broken.