Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity description might have empty parts (in Meanwhile column, mainly) #819

Closed
jankusanagi opened this issue Sep 16, 2013 · 1 comment

Comments

@jankusanagi
Copy link
Contributor

A client can publish a note with the _displayName_ property set to "" (empty string), which would result in something like "JohnDoe posted a comment in reply to", without anything after "to", where something like "a note", or a specific title for that note/picture/object should be.

While this is probably something the clients should avoid (setting the displayName property if it's empty), I guess pump.io should check for empty displayName's and treat them as "no displayName present".

This can be seen in the Meanwhile column or in notification e-mails, and can be caused, for instance, by older versions of Dianara, by posting an image with an empty title.

jankusanagi added a commit to jankusanagi/pump.io-jan that referenced this issue Oct 24, 2015
Don't use displayName in activities descriptions if it's a 0-length
string
@strugee
Copy link
Member

strugee commented Sep 17, 2016

Closing as the corresponding PR was merged just under a year ago :)

@strugee strugee closed this as completed Sep 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants