-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds filtering sandboxes by state in the SDKs #564
base: beta
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: d688463 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mishushakov please add a section to docs here mentioning how to list and delete paused sandboxes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mishushakov will deleting paused sandboxes be included in a separate PR? I'm asking because the new docs addition doesn't mention anything about deleting paused sandboxes.
Other than that, this looks good to me on the docs level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this will be a separate PR.
One more thing, I noticed that in Python, we support importing the state type: from e2b.api.client.models.get_sandboxes_state import GetSandboxesState
sandboxes = Sandbox.list(state=GetSandboxesState.PAUSED) but in JS we expect users to just pass a string: const sandboxes = await Sandbox.list({ state: 'paused' }) Why not passing just a string for Python as well? |
Has to do with the way we generate enum types for Python SDK, I will look, maybe there's a flag for string-style enums in the generator |
Adds a new optional param to filter sandboxes by state