Skip to content

Deno workarounds #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Deno workarounds #73

wants to merge 2 commits into from

Conversation

mishushakov
Copy link
Member

  • Updated to the latest version of Deno
  • Added a warmup script that runs Deno session once

Copy link
Contributor

@0div 0div left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you pls also update the deno.test.ts if indeed the deno update fixes imports not needed npm: prefix ?

fi

deno_session_id=$(echo "${deno_response}" | jq -r '.id')
curl -s -X DELETE "localhost:8888/api/sessions/${deno_session_id}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious: why are deleting the session here but not for the python kernel?

@@ -24,7 +24,7 @@ RUN npm install -g --unsafe-perm ijavascript
RUN ijsinstall --install=global

# Deno Kernel
COPY --from=denoland/deno:bin-2.0.4 /deno /usr/bin/deno
COPY --from=denoland/deno:bin-2.2.5 /deno /usr/bin/deno
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this solves the import problem correct?

@mishushakov mishushakov marked this pull request as draft March 26, 2025 09:56
@mishushakov
Copy link
Member Author

I converted to draft, I still need to do some further investigation, particularly I have to make it start reliable on new context

@ValentaTomas ValentaTomas added the improvement Improvement for current functionality label Mar 26, 2025
Copy link
Member

Please improve the name to express what the PR will achieve.

@ebramanti
Copy link

What is the status on this PR? I need to use the Deno runtime and the current version in the code interpreter is very flaky

@mishushakov
Copy link
Member Author

I am closing this as there appears to be an underlying issue with Deno where the kernel gets stuck in the "starting" state with no ability to restart. I have tried multiple approaches, including retries, but this does not fix the underlying issue.

A bug report on the Deno issue tracker was created: denoland/deno#28634

@mishushakov
Copy link
Member Author

@ebramanti what particular features of Deno do you need? We might have a fix soon that may make Deno unnecessary (typescript, top-level await, es modules)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement for current functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants