Add watch dir recursive option #210
Closed
+163
−130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add recursive directory watch support to the envd. It uses not yet released recursive feature of fsnotify library. This library was forked to https://github.com/e2b-dev/fsnotify and is now included instead of the original one.
Updated API with the
recursive
parameter as:It should be backwards compatible, as all fields in protobuf are optional. The default value is recursive=false.
Important restriction
This change limits the compatibility to Linux, Windows only.
✨
Description by Callstackai
This PR adds recursive directory watch support to the envd, utilizing a forked version of the fsnotify library. It introduces a new
recursive
parameter in the WatchDirRequest and CreateWatcherRequest messages, ensuring backward compatibility.Diagrams of code changes
Files Changed
This PR includes files in programming languages that we currently do not support. We have not reviewed files with the extensions
.sum
,.go
,.proto
. See list of supported languages.