api: implement redis cache lookups for dns when configured #261
+138
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 30, 2025
…-table-cache-e2b-1495
jakubno
reviewed
Jan 30, 2025
|
|
||
| ip = net.ParseIP(res) | ||
|
|
||
| // TODO: should we add this to |
There was a problem hiding this comment.
Can you test how fast is the Redis request, if there's like 1000 keys? If we don't store in cache, it's probably easier to reason about, but is it worth the extra time? Every request to sandbox will do DNS request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a draft but there are a couple of questions in TODOs, and I wanted to just validate that I put the logic in a reasonable way before I cycle back to this later in the week.