-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement read snapshot data logic #224
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## baseline_resync #224 +/- ##
==================================================
Coverage ? 56.74%
==================================================
Files ? 32
Lines ? 1852
Branches ? 204
==================================================
Hits ? 1051
Misses ? 711
Partials ? 90 ☔ View full report in Codecov by Sentry. |
e8783b2
to
1cf2582
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
Looking forward for the intergration testing with write path.
@koujl @JacksonYao287 pls take a review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
home_obj_(home_obj), group_id_(group_id) { | ||
home_obj_(home_obj), | ||
group_id_(group_id), | ||
snp_start_lsn_(upto_lsn) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is snp_start_lsn_ is used ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the current codes, it is only used to filter the shards in the constructor, but it might be used later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
9ae1ef8
No description provided.