Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement read snapshot data logic #224

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Conversation

yuwmao
Copy link
Contributor

@yuwmao yuwmao commented Nov 11, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 172 lines in your changes missing coverage. Please review.

Please upload report for BASE (baseline_resync@cf75abc). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/lib/homestore_backend/pg_blob_iterator.cpp 0.00% 139 Missing ⚠️
...ib/homestore_backend/replication_state_machine.cpp 0.00% 28 Missing ⚠️
src/lib/homestore_backend/replication_message.hpp 0.00% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                Coverage Diff                 @@
##             baseline_resync     #224   +/-   ##
==================================================
  Coverage                   ?   56.74%           
==================================================
  Files                      ?       32           
  Lines                      ?     1852           
  Branches                   ?      204           
==================================================
  Hits                       ?     1051           
  Misses                     ?      711           
  Partials                   ?       90           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/lib/homestore_backend/replication_state_machine.cpp Outdated Show resolved Hide resolved
src/lib/homestore_backend/pg_blob_iterator.cpp Outdated Show resolved Hide resolved
src/lib/homestore_backend/pg_blob_iterator.cpp Outdated Show resolved Hide resolved
src/lib/homestore_backend/pg_blob_iterator.cpp Outdated Show resolved Hide resolved
src/lib/homestore_backend/pg_blob_iterator.cpp Outdated Show resolved Hide resolved
src/lib/homestore_backend/pg_blob_iterator.cpp Outdated Show resolved Hide resolved
src/lib/homestore_backend/pg_blob_iterator.cpp Outdated Show resolved Hide resolved
@yuwmao yuwmao force-pushed the resync branch 3 times, most recently from e8783b2 to 1cf2582 Compare November 12, 2024 01:37
@yuwmao yuwmao requested a review from koujl November 12, 2024 02:49
src/lib/homestore_backend/pg_blob_iterator.cpp Outdated Show resolved Hide resolved
src/lib/homestore_backend/pg_blob_iterator.cpp Outdated Show resolved Hide resolved
src/lib/homestore_backend/pg_blob_iterator.cpp Outdated Show resolved Hide resolved
src/lib/homestore_backend/pg_blob_iterator.cpp Outdated Show resolved Hide resolved
src/lib/homestore_backend/pg_blob_iterator.cpp Outdated Show resolved Hide resolved
src/lib/homestore_backend/hs_homeobject.hpp Outdated Show resolved Hide resolved
src/lib/homestore_backend/pg_blob_iterator.cpp Outdated Show resolved Hide resolved
xiaoxichen
xiaoxichen previously approved these changes Nov 14, 2024
Copy link
Collaborator

@xiaoxichen xiaoxichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Looking forward for the intergration testing with write path.

@xiaoxichen
Copy link
Collaborator

@koujl @JacksonYao287 pls take a review

JacksonYao287
JacksonYao287 previously approved these changes Nov 15, 2024
Copy link
Collaborator

@JacksonYao287 JacksonYao287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/lib/homestore_backend/replication_state_machine.cpp Outdated Show resolved Hide resolved
home_obj_(home_obj), group_id_(group_id) {
home_obj_(home_obj),
group_id_(group_id),
snp_start_lsn_(upto_lsn) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is snp_start_lsn_ is used ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the current codes, it is only used to filter the shards in the constructor, but it might be used later.

koujl
koujl previously approved these changes Nov 15, 2024
Copy link
Contributor

@koujl koujl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

src/lib/homestore_backend/hs_homeobject.hpp Outdated Show resolved Hide resolved
@yuwmao yuwmao dismissed stale reviews from koujl, JacksonYao287, and xiaoxichen via 9ae1ef8 November 15, 2024 08:54
@koujl koujl merged commit 7b9819d into eBay:baseline_resync Nov 15, 2024
24 checks passed
koujl pushed a commit that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants